Hi Sanyam, ... I should have read your email earlier ;-) ... just found out and fixed the license check locally on my machine... I had a look at your changes... looks good to me.
You need anything else? Cheers, Aleks On Fri, Mar 30, 2018 at 4:42 PM Sanyam Goel <[email protected]> wrote: > Hi Avik, > > All the swagger files are removed from the License check as per Markus > suggestion[ > https://github.com/apache/fineract/pull/409#issuecomment-354417476 ], > please see the link: > https://github.com/apache/fineract/pull/409/files#diff-baadf2a612ff1f9e8d1a1347fe9b532cL113 > > And the branch is successfully able to build on my local machine. > Can you please share the error details while building on your machine. > > Thanks, > Sanyam Goel > > On Thu, Mar 29, 2018 at 12:30 PM, Aleksandar Vidakovic < > [email protected]> wrote: > >> Hi Sanyam, >> >> I'll have a look at it and test it out. >> >> Cheers >> >> >> On Wed, Mar 28, 2018, 8:53 PM Avik Ganguly <[email protected]> >> wrote: >> >>> Hi Sanyam, >>> >>> Last time (couple of months back) I tried to build your branch, it >>> failed to build and I remember having some discussion regarding the build >>> issues (although I can't seem to find that discussion in mail or Github). >>> >>> Are the build issues resolved or is there any manual steps still left >>> which needs automation to make the build successful? >>> >>> Regards, >>> Avik. >>> >>> On Thu, Mar 29, 2018 at 12:14 AM, Sanyam Goel <[email protected]> >>> wrote: >>> >>>> Hi Aleks, >>>> >>>> Have you got a chance to review the Pull Request? >>>> Please let me know if you want to discuss anything regarding the PR, we >>>> can schedule the meeting on google hangouts or skype and let's try to wrap >>>> up all the work and push it to the main codebase to boost up the release of >>>> Fineract 1.2. >>>> >>>> Thanks, >>>> Sanyam >>>> >>>> On Fri, Mar 23, 2018 at 3:00 AM, Aleksandar Vidakovic < >>>> [email protected]> wrote: >>>> >>>>> I'll try to get a look at this tomorrow >>>>> >>>>> >>>>> On Thu, Mar 22, 2018, 10:04 PM Sanyam Goel <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi Ed, >>>>>> >>>>>> All the GCI work was pushed on the same Pull Request #409. >>>>>> Please let me know if I need to do any other changes in the PR. >>>>>> >>>>>> Thanks, >>>>>> Sanyam >>>>>> >>>>>> On Fri, Mar 23, 2018 at 2:18 AM, Ed Cable <[email protected]> wrote: >>>>>> >>>>>>> Sanyam, >>>>>>> >>>>>>> I know that the Swagger work you did during GSOC for Mifos last >>>>>>> summer is all contained in the open pull request at >>>>>>> https://github.com/apache/fineract/pull/409 >>>>>>> >>>>>>> For the remaining Swagger work on the portfolio APIs that Chirag >>>>>>> completed, where are those pull requests at? >>>>>>> >>>>>>> Aleks, could you please do any final comments/review on these pull >>>>>>> requests to help assist Avik and other committers who are soon reviewing >>>>>>> and merging this code? >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> Ed >>>>>>> >>>>>>> -- >>>>>>> *Ed Cable* >>>>>>> President/CEO, Mifos Initiative >>>>>>> [email protected] | Skype: edcable | Mobile: +1.484.477.8649 >>>>>>> <+1%20484-477-8649> >>>>>>> >>>>>>> *Collectively Creating a World of 3 Billion Maries | * >>>>>>> http://mifos.org <http://facebook.com/mifos> >>>>>>> <http://www.twitter.com/mifos> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> SANYAM GOEL >>>>>> LinkedIn: https://goo.gl/6SJMg3 >>>>>> Github: https://goo.gl/u51wRZ >>>>>> Hackerrank: https://goo.gl/4kzLf7 >>>>>> +91-9818060934 <+91%2098180%2060934> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> SANYAM GOEL >>>> LinkedIn: https://goo.gl/6SJMg3 >>>> Github: https://goo.gl/u51wRZ >>>> Hackerrank: https://goo.gl/4kzLf7 >>>> +91-9818060934 <+91%2098180%2060934> >>>> >>> >>> > > > -- > SANYAM GOEL > LinkedIn: https://goo.gl/6SJMg3 > Github: https://goo.gl/u51wRZ > Hackerrank: https://goo.gl/4kzLf7 > +91-9818060934 <+91%2098180%2060934> >
