Hi Angel, I have reviewed the PR and kindly check the comments.
Can you please share the community- app PR for the same. If not present can you show us how it works in your system? Thank You, *Shruthi M R* Senior Software Engineer - Conflux Technologies [email protected] | Skype: Shruthi Rajaram | Mobile: +91-8277012716 On Tue, Jul 31, 2018 at 6:20 AM, Ed Cable <[email protected]> wrote: > Hello Angel, > > Thank you for raising this on the list again. I had been meaning to reach > out to you and your team to ensure we get your contributions into one of > the forthcoming releases. > > I've cc'd Shruthi who can take the lead on reviewing but invite all > community members (not just committers) to review and provided feedback on > changes made. > > Ed > > On Mon, Jul 30, 2018 at 4:16 PM Angel Cajas <[email protected]> wrote: > >> Hi , >> >> I created an issue some time ago to add some previously defined rates to >> calculate the minimum and maximum nominal rate for a loan. >> I committed and pushed those changes to a forked repository and crated a >> new a pull request on the dev branch of this repository: >> https://github.com/apache/fineract. >> I hope that I can get your feedback about the changes I did. >> >> Thanks for your attention >> > > > -- > *Ed Cable* > President/CEO, Mifos Initiative > [email protected] | Skype: edcable | Mobile: +1.484.477.8649 > > *Collectively Creating a World of 3 Billion Maries | *http://mifos.org > <http://facebook.com/mifos> <http://www.twitter.com/mifos> > >
