Hello everyone, Here is the link to the issue on Jira which I created explaining the problem I am facing with the PR https://issues.apache.org/jira/browse/FINCN-102
Please can someone look at it and help me out? Regards, Ruphine On Tue, 6 Nov 2018 at 23:17, Ruphine Kengne <[email protected]> wrote: > Hi Yannick, > > I have not been able to fix the problem with the PR. > > I have pulled Mark's latest commit, ran the test but it did not solve the > problem. > I will create an issue on Jira explaining the problem so as to get inputs > from other members of the community. > > Regards, > Ruphine Kengne > > On Sat, 3 Nov 2018 at 23:24, Awasum Yannick <[email protected]> wrote: > >> Hi Ruphine, >> >> Have you been able to fix the problem with your PR? >> >> If there are still problems, maybe you should create another issue and >> clearly explain the error you are having so others can take a look at it. >> Also, you might want to pull in Mark's latest commit and see if that will >> solve the problem. >> >> On Thu, Oct 25, 2018 at 9:53 AM Ruphine Kengne <[email protected]> >> wrote: >> >> > Hello Mark, >> > >> > Thanks very much for your quick reply. >> > >> > Here is the link to the PR having the error: >> > https://github.com/apache/fineract-cn-fims-web-app/pull/12 >> > >> > I have added the MatSelectModule into the imports of the TestingModule >> but >> > I still have the same error after running the test. >> > >> > Thanks >> > Ruphine Kengne >> > >> > >> > On Thu, 25 Oct 2018 at 09:27, Mark van Veen <[email protected]> >> > wrote: >> > >> > > It looks like the test in available-actions.service.spec.ts does pull >> in >> > a >> > > component which is using the MatSelect component. This is weird since >> > its a >> > > unit test for a service which should not have any references to a >> > component >> > > itself. >> > > >> > > Do you have a branch/fork/PR to share? So I can have a look and add my >> > > comments. >> > > >> > > BTW - the solution would be to add the MatSelectModule into the >> imports >> > of >> > > the TestingModule but it would be good to understand why the >> component is >> > > being pulled in first. >> > > >> > > On Mon, Oct 22, 2018 at 7:09 PM Ruphine Kengne < >> [email protected]> >> > > wrote: >> > > >> > > > Hello everyone, >> > > > >> > > > I wrote unit test for the Group service into fims-web-app, it worked >> > > > successful >> > > > but I am having an error from the AvailableActionService in the >> teller >> > > > service when I run npm run test. >> > > > >> > > > Here is the link to the error: >> > > > https://pastebin.com/9ftKYDg8 >> > > > >> > > > Here is the link to the commit for the issue FINCN-100(Write Unit >> test >> > > for >> > > > the Group service into fims): >> > > > >> > > > >> > > >> > >> https://github.com/kengneruphine/fineract-cn-fims-web-app/commit/a2355be72c8bbd0cdfc86a6fdbdeb8d9be5c2f99 >> > > > >> > > > Please can someone help me out? >> > > > >> > > > Thanks >> > > > Ruphine Kengne >> > > > >> > > >> > >> >
