Hello Isaac, Thanks for fixings the issues and merging the pull request. Am sorry I was very busy this festive period.
Happy Holidays and New Year in advance Pembe Miriam. On Sat, Dec 29, 2018 at 7:25 PM Isaac Kamga <[email protected]> wrote: > Hello Miriam, > > I've merged your pull request and fixed the issues I earlier commented > about in the ensuing commits. > > Happy Holidays and New Year in advance. > > Cheers, > Isaac Kamga. > > On Sat, Dec 8, 2018 at 2:00 AM Isaac Kamga <[email protected]> wrote: > > > Hello Miriam, > > > > Any luck with this ? > > > > I think your pull request [1] indicated that you're largely done with > > documenting the portfolio service. Could you steal a few hours from your > > tight schedule to adjust coding style, license your code and update the > PR > > [1] ? That would complete the work you've started. > > > > [1] https://github.com/apache/fineract-cn-portfolio/pull/10 > > > > Cheers, > > Isaac Kamga. > > > > On Wed, Oct 3, 2018 at 1:47 PM Isaac Kamga <[email protected]> > wrote: > > > >> Miriam, > >> > >> Patiently look into the code for the already documented services and > >> you'd observe a pattern. It'll be easier to work from there. > >> > >> Cheers, > >> Isaac Kamga > >> > >> On Wed, Oct 3, 2018 at 1:36 PM Pembe Miriam <[email protected]> > >> wrote: > >> > >>> Hello Isaac, > >>> > >>> Thanks for taking out time to respond to my email. I ran the unit test > >>> 'TestChargeDefinition' it passed all the test but the snippet was not > >>> generated in the default folder ( 'build/doc/generated-snippets/'). > >>> > >>> > >>> > >>> > >>> On Wed, Oct 3, 2018 at 1:11 PM Pembe Miriam <[email protected]> > >>> wrote: > >>> > >>>> Thanks Isaac, let me do that > >>>> > >>>> On Wed, Oct 3, 2018 at 1:09 PM Isaac Kamga <[email protected]> > >>>> wrote: > >>>> > >>>>> You should rather run the unit tests in your api docs java file , > >>>>> PortfolioApiDocumentation.java, for example. > >>>>> > >>>>> On Wed, Oct 3, 2018 at 1:07 PM Pembe Miriam < > [email protected]> > >>>>> wrote: > >>>>> > >>>>> > I clicked the build project on intellij, it was built successfully > >>>>> except > >>>>> > when i added > >>>>> > asciidoctor { > >>>>> > sourceDir 'build/doc/asciidoc/' > >>>>> > outputDir 'build/doc/html5' > >>>>> > options backend: "html", doctype: "book" > >>>>> > attributes "source-highlighter": "highlightjs", \ > >>>>> > 'snippets': file('build/doc/generated-snippets/') > >>>>> > } > >>>>> > > >>>>> > On Wed, Oct 3, 2018 at 12:58 PM Isaac Kamga <[email protected] > > > >>>>> wrote: > >>>>> > > >>>>> > > Thanks Miriam, > >>>>> > > > >>>>> > > Which command did you execute to encounter this error ? > >>>>> > > > >>>>> > > On Wed, Oct 3, 2018 at 12:32 PM Pembe Miriam < > >>>>> [email protected]> > >>>>> > > wrote: > >>>>> > > > >>>>> > > > Hello Isaac, > >>>>> > > > > >>>>> > > > Thanks for replying. The link to the error: > >>>>> > > https://pastebin.com/yfv7aFhf > >>>>> > > > > >>>>> > > > On Wed, Oct 3, 2018 at 12:27 PM Isaac Kamga < > >>>>> [email protected]> > >>>>> > > wrote: > >>>>> > > > > >>>>> > > > > Hello Pembe, > >>>>> > > > > > >>>>> > > > > When you stated at the beginning of this thread that you were > >>>>> working > >>>>> > > on > >>>>> > > > > this task,I thought you had gotten snippets generated > already. > >>>>> > > > > > >>>>> > > > > Please attach some snippets of your code so community has > more > >>>>> > > visibility > >>>>> > > > > of the problem you're facing. Are there any errors ? Do send > >>>>> links to > >>>>> > > > them > >>>>> > > > > using a pasting service. > >>>>> > > > > > >>>>> > > > > A bientot, > >>>>> > > > > Isaac Kamga. > >>>>> > > > > > >>>>> > > > > On Wed, Oct 3, 2018 at 12:01 PM Pembe Miriam < > >>>>> > [email protected] > >>>>> > > > > >>>>> > > > > wrote: > >>>>> > > > > > >>>>> > > > > > Hello everyone, > >>>>> > > > > > > >>>>> > > > > > I successfully Build and ran each of the unit test for the > >>>>> Fineract > >>>>> > > CN > >>>>> > > > > > Office microservice. The snippets were generated on the > >>>>> default > >>>>> > > folder > >>>>> > > > > ( > >>>>> > > > > > 'build/doc/generated-snippets/'). > >>>>> > > > > > I have errors when trying to build Fineract CN Portfolio > >>>>> > > microservice > >>>>> > > > > > after manually assigning the variables of the > >>>>> '*asciidocter*' > >>>>> > task > >>>>> > > in > >>>>> > > > > > component-test module's build.gradle file. > >>>>> > > > > > > >>>>> > > > > > > >>>>> > > > > > > >>>>> > > > > > On Wed, Oct 3, 2018 at 11:37 AM Pembe Miriam < > >>>>> > > [email protected] > >>>>> > > > > > >>>>> > > > > > wrote: > >>>>> > > > > > > >>>>> > > > > > > Hello everyone, > >>>>> > > > > > > > >>>>> > > > > > > I successfully ran each of the unit test for the Fineract > >>>>> CN > >>>>> > Office > >>>>> > > > > > > microservice. The snippets were generated on the default > >>>>> > folder ( > >>>>> > > > > > > 'build/doc/generated-snippets/'). > >>>>> > > > > > > I have errors when trying to build Fineract CN Portfolio > >>>>> > > > microservice > >>>>> > > > > > > after manually assigning the variables of the > >>>>> '*asciidocter*' > >>>>> > > task > >>>>> > > > in > >>>>> > > > > > > component-test module's build.gradle file. > >>>>> > > > > > > > >>>>> > > > > > > Attached to this mail is a screenshot of the error. > >>>>> > > > > > > > >>>>> > > > > > > On Fri, Sep 28, 2018 at 1:17 PM Awasum Yannick < > >>>>> > > > > > > [email protected]> wrote: > >>>>> > > > > > > > >>>>> > > > > > >> Hello Pembe, > >>>>> > > > > > >> > >>>>> > > > > > >> > >>>>> > > > > > >> Thanks for the updates...I will assign that issue to > you. > >>>>> > > > > > >> > >>>>> > > > > > >> Thanks. > >>>>> > > > > > >> > >>>>> > > > > > >> On Fri, Sep 28, 2018 at 12:27 PM Pembe Miriam < > >>>>> > > > > [email protected] > >>>>> > > > > > > > >>>>> > > > > > >> wrote: > >>>>> > > > > > >> > >>>>> > > > > > >> > Hello everyone, > >>>>> > > > > > >> > > >>>>> > > > > > >> > I am currently working on the issue: > >>>>> > > > > > >> > > >>>>> > > > > > >> > > >>>>> > > > > > >> > > >>>>> > > > > > >> > >>>>> > > > > > > >>>>> > > > > > >>>>> > > > > >>>>> > > > >>>>> > > >>>>> > https://issues.apache.org/jira/projects/FINCN/issues/FINCN-84?filter=allopenissues > >>>>> > > > > > >> > > >>>>> > > > > > >> > Which involves documenting Fineract CN Portfolio API > to > >>>>> manage > >>>>> > > > loans > >>>>> > > > > > and > >>>>> > > > > > >> > products. I was hoping that this issue could be > >>>>> assigned to > >>>>> > me. > >>>>> > > > > Thanks > >>>>> > > > > > >> > > >>>>> > > > > > >> > Yours Sincerely, > >>>>> > > > > > >> > Pembe Miriam > >>>>> > > > > > >> > > >>>>> > > > > > >> > >>>>> > > > > > > > >>>>> > > > > > > >>>>> > > > > > >>>>> > > > > >>>>> > > > >>>>> > > >>>>> > >>>> >
