When you merge the other users don't need to add the license file. You did not mess up your local branch.
Regards On Thu, 16 May 2019, 15:24 Mua Rachmann, <[email protected]> wrote: > Hi there, > > Manually adding the license in each of those files worked and build > properly. I just have a worry did i somehow mess up with my local branch > or is the PR causing those files to be generated. What if merged will this > be the same case for other users having to add the license? > > Regards, > Mua > > On Thu, May 16, 2019 at 11:21 AM Babajide Apata <[email protected]> > wrote: > >> Hello Mua, >> The best option is the second option from Kelvin, copy the license header >> and put in all the files that are missing. >> your rat report should be fine. >> >> cheers >> >> On Thu, 16 May 2019 at 06:24, ivange larry <[email protected]> wrote: >> >>> The files may not appear in the PR because they’re been ignored by Git. >>> >>> On Thu, 16 May 2019 at 04:57 Mua Rachmann <[email protected]> wrote: >>> >>>> >>>> >>>> On Thu, May 16, 2019 at 4:37 AM Kelvin Ikome <[email protected]> >>>> wrote: >>>> >>>>> Hi, >>>>> >>>>> The issue you are facing seems to be caused by newly created files not >>>>> containing a licence (the comments at the beginning of most files in the >>>>> throughout the codebase). >>>>> >>>>> Try resolving with the following command "./gradlew tasks >>>>> licenseFormatMain licenseFormatTest licenseFormatIntegrationTest". >>>>> >>>>> If the above command does not work, you can copy and paste the license >>>>> from a pre-existing file into the newly created files. >>>>> >>>>> I thought of doing this but from first sight i don't see these files >>>> in the PR so i don't know where the files are coming from. I will try the >>>> above commands and see how it goes >>>> >>>>> Kelvin >>>>> >>>>> On Thu, May 16, 2019 at 3:50 AM Mua Rachmann <[email protected]> >>>>> wrote: >>>>> >>>>>> Hello everyone, >>>>>> >>>>>> I am trying to solve >>>>>> https://issues.apache.org/jira/browse/FINERACT-728 , >>>>>> for this i need to have this PR applied on top >>>>>> https://github.com/apache/fineract/pull/515 of which i pulled and >>>>>> checked out to a clean branch successfully. >>>>>> >>>>>> I have issues building. The rat fails with the following message >>>>>> MBP-de-MACBOOK:fineract rachmann$ ./gradlew tomcatRunWar >>>>>> :rat FAILED >>>>>> >>>>>> FAILURE: Build failed with an exception. >>>>>> >>>>>> * What went wrong: >>>>>> Execution failed for task ':rat'. >>>>>> > Found 10 files with unapproved/unknown licenses. See >>>>>> file:/Users/rachmann/Documents/open_source/fineract/fineract/build/reports/rat/rat-report.txt >>>>>> >>>>>> * Try: >>>>>> Run with --stacktrace option to get the stack trace. Run with --info >>>>>> or --debug option to get more log output. >>>>>> >>>>>> BUILD FAILED >>>>>> >>>>>> Total time: 21.705 secs >>>>>> >>>>>> Here is a the copy of my rat-report.txt file of all the unapproved >>>>>> licenses file. I tried with the clean command it still doesn't work. >>>>>> >>>>>> PS - When i switch back to develop branch it works fine. I would be >>>>>> needing this in order to solve my issue any help would be appreciated >>>>>> >>>>>> Regards, >>>>>> Mua >>>>>> >>>>> -- >>> - Larry >>> >>>
