Hi Vishwas, Thanks for your answer and actions regarding this issue. Still, I wonder if the spring-boot-gradle-plugin should also be updated to match the spring boot version the project is currently using? I’m not aware of the benefits or problems that upgrading this plugin could cause.
Regards, Angel From: Vishwas Babu <[email protected]> Sent: martes, 28 de mayo de 2019 11:12 To: Dev <[email protected]> Subject: Re: Upgrade Apache Tomcat Version for Fineract Hi Angel, Thanks for looking into this issue. As you have rightly summarized, the changes made to dependencies.gradle were not reflected in dev-dependencies.gradle. The same has been updated with https://github.com/apache/fineract/pull/573 Regards, Vishwas On Tue, May 28, 2019 at 9:53 AM Angel Cajas <[email protected]<mailto:[email protected]>> wrote: Hi again. Continuing with this issue I described yesterday, apparently different versions of tomcat-embed libraries are packaged in the jar because of this line in the dev-dependencies file : providedRuntime("org.springframework.boot:spring-boot-starter-tomcat") The version isn’t provided for the spring-boot-starter-tomcat libraries so since it isn’t specified and it is using the same version from the spring-boot-gradle-plugin which hasn’t been upgraded and continues to be the 1.1.6.RELEASE version. Like I said before this may not be a major issue but this can be fixed either by specifying the spring-boot-starter-tomcat version in the dev dependencies or bumping the spring-boot-gradle-plugin version to 1.2.8. You tell If we should any of this changes it’s necessary. Thank you all for your attention From: Angel Cajas <[email protected]<mailto:[email protected]>> Sent: lunes, 27 de mayo de 2019 16:05 To: [email protected]<mailto:[email protected]> Subject: RE: Upgrade Apache Tomcat Version for Fineract Hi, I run the tomcatRunWar task and is running Ok. Also I checked the generated files and the version packaged inside them it’s the right one 8.0.30 compatible with the current Spring version. However when I run the build task with this command: -Penv=dev clean build dist It seems that is packaging 8.0.3 and 7.0.55 versions of tomcat-embed libraries in the jar and war files as seen in this picture. [cid:[email protected]] This only happens when the files are built with env parameter as dev. It may not be a big issue since apparently I’m the only one running the build task with this parameter. I will continue checking this issue and I’ll let you know if I find something else. Thanks for your attention From: Awasum Yannick <[email protected]<mailto:[email protected]>> Sent: lunes, 27 de mayo de 2019 14:04 To: Dev <[email protected]<mailto:[email protected]>> Subject: Re: Upgrade Apache Tomcat Version for Fineract Hi, Does tomcatRunWar task not work with the current code base? If this is the case, then create an issue, send a PR and we will review together. Thanks On Mon, May 27, 2019, 16:59 Angel Cajas <[email protected]<mailto:[email protected]>> wrote: Hello devs, I’ve been testing some features recently and tried to deploy Fineract using the embedded Tomcat server that it’s used while building the project with dev environment. However the next error was thrown when I tried to start the app with embedded Tomcat server: Caused by: java.lang.IllegalStateException: Expected method not found: java.lang .NoSuchMethodException It seems that Spring and Spring Boot versions were upgraded some months ago and that change also required the upgrade of Tomcat from version 7.0.54 to version 8.0.30 in the project dependencies. I changed the version and it worked for me, however I would like to know your opinions and if this change and if this has also happened to you while trying to start Fineract with the embedded server. Thanks for you attention Regards, Angel.
