Dylan,

Good job on identifying the root cause :)

While upgrading Flyway is definitely a good idea (purely from the
perspective of having the latest versions of dependencies), it probably
isn't required for the problem you are trying to solve.

Restoring the entire database (~350 Migrations) before running a TestSuite
would significantly increase the time taken for the Integration tests to
run. This could lead to other problems, ex: Travis times out jobs running
for more than 50 mins on public repos.

Would it be a better idea to fix the GlobalConfigurationTest instead ? The
change required would be to ensure that upon successful completion, this
test case has not modified any configurations (which is causing other test
cases to fail),
-> i.e update a configuration
-> validate it has been updated
-> then update the configuration back to its original value and validate
the same

Regards,
Vishwas



On Fri, Jun 21, 2019 at 7:59 AM dylanrobson <[email protected]> wrote:

> I forgot to mention that I have seen the open PR about upgrading Flyway at
> https://github.com/apache/fineract/pull/550
> With that in mind should I just try to find a way to accomplish this with
> the current Flyway version?
>

Reply via email to