Anh3h edited a comment on issue #4: FINCN-165: Enhance Fineract CN startup 
script. make it work with mac and linux.
URL: 
https://github.com/apache/fineract-cn-docker-compose/pull/4#issuecomment-529991123
 
 
   > This combines #2 and #3. I haven't yet figured out how I can accept pull 
requests. I did all the steps @awasum suggested here: 
apache/fineract-cn-fims-web-app#20 (comment) but still I don't see any "Merge" 
buttons next to PR-s.
   
   @aasaru I also faced the same issue. Make your GitHub account uses 
two-factor authentication.
   
   > @Anh3h I tested your PR with Mac and it didn't work. So I made the 
necessary adjustments so it could work both on Mac and Linux. I changed the IP 
addresses a bit to make them match the ports. So provisioner, for example, has 
port 2020 so it makes sense to assign ip that ends with .20 to it and so on. 
This way it is easier to remember.
   I think we could do both - provide a script for provisioning and also manual 
instructions. The goal eventually is to make anyone understand what needs to be 
done - so the more instructions the better I think.
   
   Yea.
   When this feature gets merged, I think we could look at providing more 
detailed instructions (alongside images) of the provisioning process. It think 
it will be easier for contributors to follow. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to