aasaru commented on a change in pull request #6: FINCN-165: Implement bash 
scripts to provisioner fineract cn services
URL: 
https://github.com/apache/fineract-cn-docker-compose/pull/6#discussion_r326287449
 
 

 ##########
 File path: bash_scripts/provision.sh
 ##########
 @@ -0,0 +1,318 @@
+#!/bin/bash
+set -e
+
+function init-variables {
+    local file="../env_variables"
+
+    CASSANDRA_REPLICATION_TYPE="Simple"
+    CASSANDRA_CONTACT_POINTS='172.16.238.68:9042' #initialized by the start-up 
script
+    CASSANDRA_REPLICAS="1"
+    POSTGRES_DRIVER_CLASS="org.postgresql.Driver"
+    POSTGRES_HOST='172.16.238.66' #initialized by the start-up script
+    POSTGRES_PWD="postgres"
+
 
 Review comment:
   I think you should add:
   
       POSTGRES_PORT="5432"
       POSTGRES_USER="postgres"
   
   as you refer to them on lines 117 and 118

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to