Hi Ivan,
On Thu, Nov 21, 2019 at 10:26 AM Ivan Bondarenko <[email protected]> wrote: > Hi, Ed, Awasum, All > > 1) My tests are passing locally, I have ran it many times. > 2) My local machine has really powerful configuration. I think there is > some race conditions in the integration tests that cause the random test > fail. > I noticed this. Even on Travis you see some Optimistic locking problems once in a while. Maybe an issue should be created for this? > 3) Awasum, I have just connected mifos-comunity app to the upgraded > version of the back-endand it works fine. > Do you use basic auth mode? If not please update the code. I have just > committed fix for oauth config, hope it helps. > If you use basic - could you confirm that > `V353__migrate_passwords_to_ss_5.sql` was executed on startup? > Yes,..I missed this..I was using my old DB for testing which had flyway versions above 353 and so could not log in. I used a clean DB now and i can login from UI. Thanks Ivan. > PS: Unfortunately I have found that integration tests have bugs and some > critical cases are not covered, examples : > 1) As I can see `HookIntegrationTest.shouldSendOfficeCreationNotification` > will pas in any case, it has no assertions(just "sout" logging) > 2) I can't find tests with oauth config > 3) Can't find test for documents and image uploads > 4) I think there is some race conditions on job execution and job's status > checks in integration tests. (I hope get it wrong) > > I will create jira issues for found problems, but a little bit later. (If > someone confirm the described issues it would be really helpfull) > You are right on all the above. Go ahead and create issues on Jira for these. Thanks for your contributions and patience, Ivan. чт, 21 нояб. 2019 г. в 09:51, Awasum Yannick <[email protected]>: > >> Hi All, >> >> I left some review comments here: >> https://github.com/apache/fineract/pull/642#issuecomment-556962459 >> on why Travis is failing and also problems when connecting the front end >> to the upgraded (Spring 5.x) Fineract branch/PR. >> >> Any ideas? >> >> On Wed, Nov 20, 2019 at 11:18 PM Ed Cable <[email protected]> wrote: >> >>> Hi all, >>> >>> I just wanted to follow up on this as we're trying to wrap up the 1.4 >>> release and bring it to a vote. >>> >>> Ed >>> >>> On Fri, Nov 15, 2019 at 12:01 PM Ed Cable <[email protected]> wrote: >>> >>>> Michael and Ivan, >>>> >>>> So we can ship the 1.4 release on time, I wanted to inquire about the >>>> status of merging https://github.com/apache/fineract/pull/642 >>>> >>>> Is there anything blocking it? It looks like Ivan's test are passing >>>> locally but the build is still failing. >>>> >>>> Once that's merged, I believe we can then merge >>>> https://github.com/apache/fineract/pull/649 >>>> >>>> THanks, >>>> >>>> Ed >>>> >>>> >>> >>> -- >>> *Ed Cable* >>> President/CEO, Mifos Initiative >>> [email protected] | Skype: edcable | Mobile: +1.484.477.8649 >>> >>> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org >>> <http://facebook.com/mifos> <http://www.twitter.com/mifos> >>> >>>
