On Fri, Jul 19, 2019 at 8:53 PM Awasum Yannick <[email protected]> wrote:
> Is someone interested to look into this. > > Angel, i think you could merge your PR and also send in PRs for the UI. > Make sure you update the user manual and documentation on how to use this > feature. > I just noticed that this old PR (https://github.com/apache/fineract/pull/592) from Angel was *STILL* not merged - really sorry about this Angel, I know from my own experience in open source that it can be very frustrating if one puts in the time to raise a PR which then gets ignored - we still have "some room for improvement" in this regard as a community... ;-) I've just rebased this PR, but it now fails to build due to something minor (see comment on PR). If you'd still be willing to address that, I'd be very happy to finally merge this PR ASAP, even without any further functional review, as 6 months (!) seem much more than enough for any interested party having any objections to this to speak up. PS: As 2019 draws a close, let us all try to wrap up all pending PRs, and either merge or close anything that's clearly abandoned? (One can always raise new ones.) > On Sat, Jun 29, 2019 at 3:29 PM Awasum Yannick <[email protected]> wrote: > >> Hi All, >> >> Angel Cajas has put in alot of work to work on this PR and addressed >> numerous feedback. >> https://github.com/apache/fineract/pull/592 >> >> Is there anyone willing to review the above. >> >> I would have been able to review the feature but am not familiar with the >> use case. >> >> Is there a UI or Spec doc for this feature which will ease review? >> >> Santosh, Ed, are you both in a position to review this PR and see if you >> could merge. Or will everyone be comfortable if Angel merged this into >> develop afterall, Angel is a committer. >> >> >> Thanks. >> Awasum >> >>
