On Fri, Mar 20, 2020 at 5:28 AM RAHUL PAWAR <[email protected]> wrote:
> Hi Ed, > > Yes, the build is passing locally in machine. > That is very curious, I don't see how that's possible; you should see the same failures that Travis CI reports... ...do make sure that you rebase to the latest master, and run a full "./gradlew build" and you will reproduce the Checkstyle errors that Travis shows if you click on Details. I've also just commented on the https://github.com/apache/fineract/pull/738 with some more suggestions re. Checkstyle, for anyone interested to read. > Thanks. > > On Fri, Mar 20, 2020 at 6:37 AM Ed Cable <[email protected]> wrote: > >> Wonderful news. We'll try to get it merged promptly. >> >> I'm adding @Dev <[email protected]> >> >> It's showing the Travis CI build is failing - the build is passing >> locally for you? >> >> On Thu, Mar 19, 2020 at 7:04 AM RAHUL PAWAR <[email protected]> >> wrote: >> >>> Hi Ed, >>> >>> The Integration Test for glim_gsim has been completed and along with it, >>> also fixed some bugs regarding it. >>> >>> Pr: https://github.com/apache/fineract/pull/738 >>> >>> Thankyou. >>> >>> On Thu, Jan 2, 2020 at 8:22 AM Ed Cable <[email protected]> wrote: >>> >>>> Thank you for the update. >>>> >>>> On Wed, Jan 1, 2020, 07:02 RAHUL PAWAR <[email protected]> wrote: >>>> >>>>> Hi Ed, >>>>> I am still working on testcases, will be completed soon. >>>>> >>>>> On Wed, Nov 13, 2019 at 7:23 AM Nikhil Pawar <[email protected]> >>>>> wrote: >>>>> >>>>>> I am going to take this up with Rahul this holidays, will keep you >>>>>> posted. >>>>>> >>>>>> On Tue, Nov 12, 2019 at 8:45 PM Ed Cable <[email protected]> wrote: >>>>>> >>>>>>> Hi Rahul and Nikhil, >>>>>>> >>>>>>> I would love to get this work shipped to the community. Did you get >>>>>>> a chance to write the necessary test cases? It's likely we'll target 1.5 >>>>>>> release for this. >>>>>>> >>>>>>> See https://github.com/apache/fineract/pull/527 >>>>>>> >>>>>>> and https://issues.apache.org/jira/browse/FINERACT-603 >>>>>>> >>>>>>> Ed >>>>>>> >>>>>>> >> >> -- >> *Ed Cable* >> President/CEO, Mifos Initiative >> [email protected] | Skype: edcable | Mobile: +1.484.477.8649 >> >> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org >> <http://facebook.com/mifos> <http://www.twitter.com/mifos> >> >>
