Devs,

While I was going through a PR- it occurred to me that we should adapt this
new coding standard which will largely simplify the life of the reviewer.

Whenever we are writing a new feature and if involves refactoring, we
should separate Refactored code with a new Feature code.
Such differentiation  helps reviewer to examine refactoring with the lens
of whether this change has broken existing behavior ( may be just look unit
test cases) and breeze through.

And while evaluating new feature commit just examine whether the new
feature really achieves the goal of new requirement without having to worry
about it breaking existing behavior.

Of course it is difficult to estimate before hand whether the change will
require refactoring or not, but once we know it , we should segregate the
changes.

If interested there is a nice talk on refactoring by Martin Fowler:
https://youtu.be/vqEg37e4Mkw

Regards,
Nikhil

Reply via email to