On Thu, 30 Apr 2020, 16:13 Saransh Sharma, <[email protected]> wrote:
> if after all if you agree i can add prettier formatting as a part of the > pre-commit hook, https://github.com/apache/fineract/pull/771 > > On Thu, Apr 30, 2020 at 7:41 PM Saransh Sharma <[email protected]> > wrote: > >> I know there is checkStyle enforced, but code is not pretty , I have used >> the prettier formatting from >> >> https://github.com/jhipster/prettier-java >> >> It has made the code base style pretty consistent and is more readable. >> For instance , it uses this technique: A Prettier plugin must first parse >> the source code of the target language into a traversable data structure >> (Usually an Abstract Syntax Tree) and then print out that data structure in >> a "pretty" style. Prettier-Java uses a Java-Parser implemented in >> JavaScript using the Chevrotain Parser Building Toolkit for JavaScript. >> What this means is that unlike many other Prettier plugins, prettier-java >> has no additional runtime pre-requisites (e.g: Python executable). >> > But it seems to require Node.JS, apparently? Fineract (backend) being pure JVM, do we really want to require everyone having to have (else build fails) NPM? I'm concerned this adds complexity, for "just" a code formatter.. Isn't there some other tool similar to this but which is pure Java only, and truly without any additional runtime pre-requisites than the JVM? It could even be used inside a browser. >> >> CheckStyle is enforced, i think i like prettier one. >> >> If you guys agree to it, we can open an issue and PR. >> >> >> -- >> >> Saransh Sharma >> *Research Partner* >> *Muellner Internet Pvt Ltd * >> >> >> ---------------------------------------------------------------------------------------------- >> >> The idea of separation of me and you is amazing. >> >> ---------------------------------------------------------------------------------------------- >> *Company Website <https://www.muellners.com/> **Company Linkedin >> <https://www.linkedin.com/company/muellners> *Company Facebook >> <https://www.facebook.com/muellners> >> >> This mail is governed by Muellner® Internet Private Limited's IT policy. >> The information contained in this e-mail and any accompanying documents >> may contain information that is confidential or otherwise protected from >> disclosure. If you are not the intended recipient of this message, or if >> this message has been addressed to you in error, please immediately alert >> the sender by reply e-mail and then delete this message, including any >> attachments. Any dissemination, distribution or other use of the contents >> of this message by anyone other than the intended recipient is strictly >> prohibited. All messages sent to and from this e-mail address may be >> monitored as permitted by applicable law and regulations to ensure >> compliance with our internal policies and to protect our business. E-mails >> are not secure and cannot be guaranteed to be error free as they can be >> intercepted, amended, lost or destroyed, or contain viruses. You are deemed >> to have accepted these risks if you communicate with us by e-mail. >> > > > -- > > Saransh Sharma > *Research Partner* > *Muellner Internet Pvt Ltd * > > > ---------------------------------------------------------------------------------------------- > > The idea of separation of me and you is amazing. > > ---------------------------------------------------------------------------------------------- > *Company Website <https://www.muellners.com/> **Company Linkedin > <https://www.linkedin.com/company/muellners> *Company Facebook > <https://www.facebook.com/muellners> > > This mail is governed by Muellner® Internet Private Limited's IT policy. > The information contained in this e-mail and any accompanying documents > may contain information that is confidential or otherwise protected from > disclosure. If you are not the intended recipient of this message, or if > this message has been addressed to you in error, please immediately alert > the sender by reply e-mail and then delete this message, including any > attachments. Any dissemination, distribution or other use of the contents > of this message by anyone other than the intended recipient is strictly > prohibited. All messages sent to and from this e-mail address may be > monitored as permitted by applicable law and regulations to ensure > compliance with our internal policies and to protect our business. E-mails > are not secure and cannot be guaranteed to be error free as they can be > intercepted, amended, lost or destroyed, or contain viruses. You are deemed > to have accepted these risks if you communicate with us by e-mail. >
