Hi

Yes, looks like the JPA queries used to look up the note for update / delete 
are broken - that’s why they never find the note to be updated.

I’m not sure how this has ever worked - but I can send a PR later tonight to 
fix this. Will also add some integration tests to ensure we catch this next 
time. 

Regards
Petri


> On 27 Sep 2020, at 4:50 PM, David Yahalomi <[email protected]> wrote:
> 
> Hey All,
> 
> IDK if that was always the case, but it seems like update and delete of 
> client note is broken. 
> I think the other resources are in the same condition. 
> From what I can tell, the fault is in the NoteRepository. Could someone 
> confirm this issue?
> 
> I looked in the JIRA and could not find a ticket about it so I am not sure if 
> this is a less used feature or what.
> I was able to reproduce it both on our FaaS and on the more up to date, 
> fineract.dev <http://fineract.dev/> deployment so I think it has been there 
> for quite some time.
> 
> Would appreciate any feedback.
> 
> Thanks,
> 
> David Yahalomi 
> Co-Founder     
>  
> Rothschild Blvd 3, Tel Aviv-Yafo, Israel
> mobile: + 972 52 817 9787
> email: [email protected] <mailto:[email protected]>
>   <https://articode.co/>

Reply via email to