Hello, I think this change is Ok to be in the develop branch (the fix).
1.5 Is tagged and it is not included there (which is ok). 1.5.1 could include this fix. El lun, 18 oct 2021 a las 10:09, Benura Abeywardena (<[email protected]>) escribió: > Hi James, > > I think this change doesnt exist in finersct 1.5.0 release since the PR > was merged in the last month. Agree with you on not committing the feature > without making it optional. However, there's a commit to revert this > property (back to as optional). > > Thanks and Regards, > Benura > > On Mon, 18 Oct 2021, 20:25 James Dailey, <[email protected]> wrote: > >> Benura >> >> Thanks for this. >> >> I'm a bit concerned about this statement: >> >> "During GSOC 2021, we made this field mandatory while creating a loan >> account" >> >> Did this code change (making a field mandatory in Fineract) arise during >> GSOC and then automatically make its way into the formal release? >> >> Seems like that was a PR that should not have been committed. Do I have >> that right? >> >> >> >> >> On Sun, Oct 17, 2021, 1:00 PM Benura Abeywardena <[email protected]> >> wrote: >> >>> Hi, >>> >>> I think this commit has already resolved that issue. >>> https://issues.apache.org/jira/browse/FINERACT-1405?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel >>> >>> During GSOC 2021, we made this field mandatory while creating a loan >>> account. Please try rebasing the latest commits. You can refer to this gist >>> link to get some idea on what changes we have done during the past summer >>> (2021) >>> https://gist.github.com/BLasan/bd21154ab9cc69e996a9e5aa0395cc03 >>> >>> Thanks & Regards, >>> Benura >>> >>> On Mon, Oct 18, 2021 at 1:12 AM ondur kiyelo <[email protected]> wrote: >>> >>>> Hello Team, >>>> >>>> Am using Mifos 21.07.01 but get this error below when I am adding a >>>> loan to a client but on 18.03 (seems not to be mandatory ,it works well. >>>> What can I do to resolve this? >>>> >>>> thank you >>>> >>>> >>>> [image: image.png] >>>> >>>>
