see: https://github.com/apache/fineract/pull/1986
On Sat, Nov 27, 2021 at 11:57 PM Aleksandar Vidakovic < [email protected]> wrote: > Hi @Petri Tuomola <[email protected]> and all, > > ... I am preparing a fix for that... actually my PR will contain a bit > more: > > - my initial intent was to introduce proper Docker builds via Google > Jib plugin > - ... and in a second step replace the Tomcat Cargo, because the setup > is brittle and strictly speaking we are not testing our main deliverable > (single JAR Spring Boot app), but the outdated WAR file > - ... I know, not much of a difference... but if you look at the > setup... there are just too many moving parts > - instead I'm using (in my PR) everything that we already have: > pre-built Docker image (with Jib) and the Docker Compose file we have in > the root folder; voila, no more external dependency on Mysql (i. e. our > Github workflow can run on Ubuntu 20.04... or any other OS for that > matter); and we can test on dev machines without a long laundry list of > setup steps (more in my PR description) > - we had actually some regressions with our upgrade to JDK 17: GSON is > using reflection extensively which is not allowed anymore (well, a lot more > restrictive) in JDK 17; a bunch of integration tests were failing > - more JDK 17: I've fixed some JVM args for Gradle related to JDK 17 > (also a reason why Travis was failing); this one affected some Spotless > tasks > > I am currently running the integration tests, 436 executed, of which 40 > failed (most of them related to the GSON issue I mentioned) and some file > system related issues due to running in a Docker container (very easy fix). > > As the whole test suite is running quite long I suggest to approve the PR > (if you agree to this approach) even if some of tests still fail; we can > take care of them later (with better visibility). > > Just fixing as many of the GSON related issues as I can... PR on the way. > > FYI > > On Sat, Nov 27, 2021 at 1:04 AM Petri Tuomola <[email protected]> > wrote: > >> All >> >> As per the email discussion a couple of weeks ago, we’ve had both Travis >> and GitHub Action builds running in parallel for each PR. >> >> Throughout this time, it’s been clear that GitHub Action builds have been >> both faster as well as more reliable. >> >> As running two builds to do the same doesn’t really add value (and >> especially as the Travis one often fails for spurious reasons), I’ve >> disabled the actual build & integration test from Travis build. Going >> forward, Travis build only does the Sonarqube scan (which cannot be done >> from GitHub Action due to lack of ability to store the secrets anywhere). >> >> Because of this, when reviewing / merging PRs, please make sure that ALL >> three checks (2x GitHub and 1x Travis) pass with GREEN status before >> merging. >> >> Hope this makes sense - happy to discuss >> >> Regards >> Petri >> >>
