Hi Ed, Wow, that's great you were able to grab the docs and the email thread. I checked both and it confirms my theory. The topic and topic_subscriber tables were unnecessary in the picture to achieve the behavior we wanted.
@Victor: thanks for the info. Best, Arnold On Wed, May 18, 2022 at 5:22 PM VICTOR MANUEL ROMERO RODRIGUEZ < [email protected]> wrote: > Hello Arnold, > > For the classical UI some events were not passed to the UI (details > URL) because the Event property names were not matching. > > I think it is still open .. > > https://github.com/openMF/community-app/pull/3441 > > Regards > > Victor > > El mié, 18 may 2022 a las 10:10, Arnold Galovics (< > [email protected]>) escribió: > >> Hi guys, >> >> Thanks for the feedback. I can only agree with you, we don't want to lose >> features that are potentially used. >> >> I was probably not crystal clear when I mentioned the term "notification >> topic". I was mainly referring to the "topic" and "topic_subscriber" tables >> which are currently not exposed through APIs but only used for our internal >> purpose. However, after spending some time on understanding what the >> purpose was behind this, I figured out that these tables and their related >> functionality is not even needed to maintain the completeness of our >> feature set so I was able to replace it fairly easily and get rid of the >> related code. >> >> I'm still polishing the PR, but you can look at it here: >> https://github.com/apache/fineract/pull/2330 >> >> Just as a side note, these 2 tables are also used in conjunction with the >> UI notifications (on the top of the UI) and I realized that the UI >> notification feature is not even working without a running ActiveMQ broken >> because the logic is buggy. >> >> I managed to fix that as well as part of the cleanup and I introduced a >> new test-case to verify this logic. >> >> Summary: >> - ~1500 less lines of unnecessary code >> - A simplified notification implementation >> - New test case to verify UI notifications >> >> Best, >> Arnold >> >> >> On Wed, May 18, 2022 at 5:02 PM James Dailey <[email protected]> >> wrote: >> >>> Yes, we have to be careful about removing things, that is probably an >>> unspoken principle on this project as we don't know how it's being used. >>> (unfortunately) >>> However, if it makes sense from an architectural perspective to >>> rationalize the notification and event handling frameworks, then I would >>> suggest that we find a way to migrate this behavior. >>> ... and wondering if this belongs in its own extension or outside >>> component. >>> >>> It may be "half-implemented" but that doesn't mean it isn't being used. >>> ;) >>> >>> >>> On Wed, May 18, 2022 at 7:43 AM Bharath Gowda <[email protected]> wrote: >>> >>>> Hi Arnold, >>>> >>>> I have some organizations using the notification feature effectively >>>> for sanctioning or disbursing the loan accounts based on the notifications >>>> which they receive. It is mainly useful when there are different levels of >>>> approvals for the loan cycle. >>>> >>>> (user configuration document for this feature is here >>>> <https://docs.mifos.org/mifosx/user-manual/for-administrators-mifos-x-platform/configure-notifications> >>>> ) >>>> >>>> Regards, >>>> Bharath >>>> Lead Implementation Analyst | Mifos Initiative >>>> Skype: live:cbharath4| Mobile: +91.7019635592 >>>> http://mifos.org <http://facebook.com/mifos> >>>> <http://www.twitter.com/mifos> >>>> >>>> >>>> On Wed, May 18, 2022 at 3:29 PM Aleksandar Vidakovic < >>>> [email protected]> wrote: >>>> >>>>> ... thanks Adam... learned again. >>>>> >>>>> On Wed, May 18, 2022 at 10:28 AM Ádám Sághy <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi guys, >>>>>> >>>>>> So lets see what i know about this functionality: >>>>>> >>>>>> - The Fineract is the publisher and also a listener for the >>>>>> Notification events. >>>>>> >>>>>> - Fineract is publishing notifications in the following situations: >>>>>> "ACTIVATE_CLIENT" >>>>>> "ACTIVATE_CENTER" >>>>>> "ACTIVATE_GROUP" >>>>>> "READ_SAVINGSACCOUNT" >>>>>> "READ_DIVIDEND_SHAREPRODUCT" >>>>>> "APPROVE_FIXEDDEPOSITACCOUNT" >>>>>> "APPROVE_RECURRINGDEPOSITACCOUNT" >>>>>> "ACTIVATE_FIXEDDEPOSITACCOUNT" >>>>>> "ACTIVATE_RECURRINGDEPOSITACCOUNT >>>>>> "ACTIVATE_SAVINGSACCOUNT" >>>>>> "READ_SAVINGSACCOUNT" >>>>>> "APPROVE_LOAN", >>>>>> "DISBURSE_LOAN" >>>>>> "READ_LOAN" >>>>>> "READ_Rescheduled Loans" >>>>>> "READ_LOAN" >>>>>> "READ_LOANPRODUCT" >>>>>> "APPROVE_SAVINGSACCOUNT" >>>>>> "READ_SAVINGSACCOUNT" >>>>>> "APPROVE_SHAREACCOUNT" >>>>>> “ACTIVATE_SHAREACCOUNT” >>>>>> >>>>>> - There is a topic subsciption functionality also where appusers can >>>>>> subscribe for events and they got notified when that event occured. >>>>>> - When a user is created based on the roles, the fineract might >>>>>> subscribe automatically for topics >>>>>> >>>>>> - Fineract listener are listening for these kind of events and when >>>>>> it happens it will create a notification entry into the database for the >>>>>> subscribed users. >>>>>> - When a subscribed user logs into the Fineract, they will get the >>>>>> notification (on the UI for example a popup). >>>>>> >>>>>> I hope it helps to visualize this functionality a little bit better >>>>>> and decide on its future. >>>>>> >>>>>> Regards, >>>>>> Adam >>>>>> >>>>>> On 18 May 2022, at 09:56, Aleksandar Vidakovic < >>>>>> [email protected]> wrote: >>>>>> >>>>>> ... other question: does it do anything? I'll have another look at it >>>>>> today, but it seems non-functional. >>>>>> >>>>>> It's going to be hard to reach in general a consensus if people are >>>>>> not participating... same argument could be made for introducing >>>>>> Liquibase; >>>>>> I'm sure that others invested time in Flyway, but we still replaced it. >>>>>> >>>>>> Just my 2 cents. >>>>>> >>>>>> On Wed, May 18, 2022 at 9:43 AM Awasum Yannick <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Hello Aleks and Arnold, >>>>>>> >>>>>>> I won't remove that feature given we don't know who may or may not >>>>>>> be using it. >>>>>>> >>>>>>> There are people using Fineract who are not even on this dev list or >>>>>>> participating in conversations. >>>>>>> >>>>>>> I would be careful with what I remove even if it looks unusable to >>>>>>> me. >>>>>>> >>>>>>> On Wed, May 18, 2022, 02:11 Aleksandar Vidakovic < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> I would say: +1 >>>>>>>> >>>>>>>> On Tue, May 17, 2022 at 10:01 PM Arnold Galovics <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi guys, >>>>>>>>> >>>>>>>>> I'm exploring the current event handling frameworks available in >>>>>>>>> Fineract - Hooks, Business events and Notification events - and I was >>>>>>>>> wondering if anybody is using the so called "topic subscriptions" in >>>>>>>>> Fineract within the Notification events module. >>>>>>>>> >>>>>>>>> As far as I can tell, it's a half-complete implementation but I >>>>>>>>> see that upon creating a new user and assigning it to an office, it >>>>>>>>> automatically subscribes the user to a particular topic but the >>>>>>>>> notion of >>>>>>>>> "subscribing to a topic" doesn't really have any meaning at this >>>>>>>>> point. >>>>>>>>> >>>>>>>>> If nobody is using the feature, I'll just remove it to get rid of >>>>>>>>> some of the weight we've been carrying. >>>>>>>>> >>>>>>>>> Let me know. >>>>>>>>> >>>>>>>>> Best, >>>>>>>>> Arnold >>>>>>>>> >>>>>>>> >>>>>>
