Hi Arnold and Hemant,

... I think the PR is not correct:

   - @Setter is missing (we said no more immutability, because of dev
   experience)
   - @NoArgsConstructor(access = AccessLevel.PROTECTED) is against the JPA
   spec (requires a public no args constructor
   - if the constructor with parameters is relatively easy to replace
   by @RequiredArgsConstructor then we should do this (probably order of
   parameters needs to be refactored

@Hemant Gupta <[email protected]> please check the documents and
notes again we created.

Cheers,

Aleks

Reply via email to