Devs - I'd like to have a discussion around code quality and process quality.
@alexs remarked during the release process of 1.8 (in process) that he wasn't always able to find a related Jira ticket for the PR or commit. This is a big problem! We should, in my view, simply revert or remove any contribution that doesn't have the proper documentation of WHY it is there and HOW the developer came to a specific design or approach. Also PRs and commits must have the proper format and should not happen without a jira ticket. I understand that this happens sometimes because people are "on deadlines" and need the feature right away... but I also know that sometimes the discovery process, which is implied by the jira ticketing idea, gets to a different solution. For example, perhaps there is a way to configure a consumer facing product that doesn't involve placing your specific requirement in the java data class. There are other built out mechanisms. This surfaces the second problem: maintainability of the code. Maintainability is a squishy concept but you know it when it fails - projects get harder to work on - code is not understandable, the reasons for the code changes are unclear or illogical, new features and functionality are harder and harder to add. Tests sometimes catch this, but often not. Fundamentally, quality, maintainability, and security are all "collective action". We all have to agree to do it and have high standards. We need a new agreement. So, I invite some comments here and propose a quality alignment zoom meeting for any active projects using Fineract. Fineract is being used in production so it is increasingly important that we ensure a quality mindset. Then, we document the agreement and bring it back to the list and the wiki. We can use this as a follow up on the previous QA and testing discussion: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=195730039 Proposed Zoom call: 7am PDT next week on Wednesday , Aug 31st 9am CDT 4pm CEST 7:30pm IST I'll send out details if you want to attend. Please contact me directly. Thanks, James
