Hello everyone, I have noticed a potential bug in POST query for FD accounts. After FD account creation, there are a number of actions that can be performed on the account like approval/rejection of request, premature close, close, etc. The path param takes the FD account id and the query param takes the command type. However, I noticed that we are also setting the savingsID the same as FD account id in the CommandWrapperBuilder.
This feels incorrect to me due to the following reasons: 1) FD account can be created independent of any savings account in my knowledge, hence, I don't see the point of adding a savings id there. 2) Even if FD account is dependent on a savings acc, is it always true that there ID will always be the same? 3) If FD account is dependent on savings account, then this needs to be handled during FD account creation as well because right now there is no such check at the time of FD creation. Can someone please clarify? Regards, Uddyan Goyal
