Great. it works now.
Please review the PR for any additional changes needed..

If there's a quicker method available, I'd like to learn about it.
As shown in the attached picture, the following command took ~1 hour to
complete:
./gradlew clean build jibDockerBuild -x test -x cucumber

Thanks!

On Thu, Jun 27, 2024 at 8:00 AM Aleksandar Vidakovic <
chee...@monkeysintown.com> wrote:

> ... just undo your changes concerning that plugin, remove everything
> "bmuschko" related (which makes the pull request also smaller and more
> acceptable). The relevant section in the build.gradle file is here:
>
>
> https://github.com/apache/fineract/blob/b482fbd44728bf78dd68a4f130a7ced497526607/custom/docker/build.gradle#L25
> (from the develop branch)
>
> ... and specifically I meant this line:
>
>
> https://github.com/apache/fineract/blob/b482fbd44728bf78dd68a4f130a7ced497526607/custom/docker/build.gradle#L27
>
> .... where you just provide the upstream base image (it's a public one on
> Docker Hub, so nothing needs to be prepared here):
>
> [code]
>
> image = 'azul/zulu-openjdk-alpine:17'
>
> [/code]
>
>
> On Thu, Jun 27, 2024 at 5:24 AM Zeyad Nasef <zeyad.nasef....@gmail.com>
> wrote:
>
>> Hello everyone, Hope you are doing well.
>> I am working on creating a new custom API layer using Spring Web MVC
>> related to this Jira ticket FINERACT-2021
>> <https://issues.apache.org/jira/browse/FINERACT-2021>.
>>
>> Now, I added the following changes for building and publishing a custom
>> image on my docker hub account using `bmuschko` plugin:
>>
>> ```
>> tasks.create("dockerCreateDockerfile", Dockerfile) {
>>     from("azul/zulu-openjdk-alpine:21.0.3-jre")
>>     label(["maintainer": "Zeyad Nasef <zeyad.nasef....@gmail.com>"])
>>     instruction 'RUN apk add --no-cache msttcorefonts-installer
>> fontconfig'
>>     instruction 'RUN update-ms-fonts'
>> }
>>
>> task dockerBuildImage(type: DockerBuildImage) {
>>     images.add('zeyad2003/fineract-base:latest')
>>
>>     dependsOn dockerCreateDockerfile
>> }
>>
>> task dockerPushImage(type: DockerPushImage) {
>>     images.add('zeyad2003/fineract-base:latest')
>>
>>     dependsOn dockerBuildImage
>> }
>> ```
>>
>> Now that was the only way that I could run and see my changes through.
>> But the following comment
>> <https://github.com/apache/fineract/pull/3915#discussion_r1654404951>
>>  said:
>>
>> >> just create the custom Fineract image deriving from a publicly
>> available base image (like the default Fineract image; look into
>> fineract-provider).
>>
>> But I couldn't understand how to do it, I tried to run the
>> `:custom:docker:jib` task and it gave me an unauthorized error (401).
>>
>>
>> *So could anyone help to run these changes with docker and
>> docker-compose?*
>> Thanks!
>>
>

Reply via email to