Zayed - Thanks for sharing, good transparency! Arnold - does this respond to the concerns you raised in the github comments?
On the substance, you’ve laid out your case and provided examples and a design concept. If I understand correctly, you will set up some few examples but not fully implement across all components. If that’s the case, then this becomes a problem for maintaining as it is unlikely anyone else will take it up. It might be better to simply show this as a PR and point to your fork for demonstration purposes. Let me know if I’ve got that right. And provide a response. Thanks On Mon, Jul 15, 2024 at 12:53 AM Zeyad Nasef <zeyad.nasef....@gmail.com> wrote: > Hello everyone, > > I hope you're doing well. > > I am currently addressing the type-safety issue with write requests (aka.. > commands) in our project. > After thoroughly exploring the execution flow multiple times, I have > documented my findings, highlighting the issues with the current execution > flow and proposing potential solutions. Additionally, I have included some > questions to better understand the current design. > > I would greatly appreciate it if you could review the document and provide > any suggestions for resolving this issue. If there are any unclear or > missing parts, please let me know. > > The document link > <https://docs.google.com/document/d/14uE-m2Y9BB_un0JVfVALudO-LPb4QvSlaAew0mOGDBs/edit?usp=sharing> > > Jira ticket link <https://issues.apache.org/jira/browse/FINERACT-2021> > > Also, @chee...@monkeysintown.com <chee...@monkeysintown.com> left an > important related comment here > <https://github.com/apache/fineract/pull/3915#issuecomment-2213566671>. > > Thank you! > > Best regards, > Zeyad Nasef >
