... this still needs to be fleshed out a bit more... before it makes sense to involve a wider audience... FYI
On Tue, Jul 30, 2024 at 8:03 AM Zeyad Nasef <zeyad.nasef....@gmail.com> wrote: > Hi Adam. Thanks for your reply and sorry for my delay. > > Here's the image link > <https://github.com/user-attachments/assets/df499ab4-08f1-4e32-91ac-caa6212e423b> > that > shows the execution flow. > > Also, feel free to join the Slack channel > <https://mifos.slack.com/archives/C0758AHN2LF> for this project. > It's better to come here (The mailing list) when presenting a working > solution. > > Best Regards, > Zeyad > > On Mon, Jul 29, 2024 at 9:29 PM Ádám Sághy <adamsa...@gmail.com> wrote: > >> Hi >> >> The “blue boxes here” link is not really working to me. Would you please >> share as part of your email all the details we need to know? >> >> Regards, >> Adam >> >> On 29 Jul 2024, at 15:04, Zeyad Nasef <zeyad.nasef....@gmail.com> wrote: >> >> Hello everyone, >> >> I hope you are all doing well. >> >> Two weeks ago, I initiated a thread >> <https://lists.apache.org/thread/7vzxzol048qojmc4kry5v4ybwgdf050y> >> regarding the introduction of type-safety to the write requests' (aka.. >> commands) execution flow. I highlighted several issues within the current >> flow that complicate maintenance and the development of new features, as >> well as some initial solutions. >> >> At present, I am working on a PR >> <https://github.com/apache/fineract/pull/3994> to demonstrate a proof of >> concept for improving this flow. However, I have encountered a challenge >> with replacing the three intermediate services (Blue boxes here >> <https://private-user-images.githubusercontent.com/380079/346514595-1357016c-3650-4b71-8e9d-1b6f671617fe.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIyNTg0OTAsIm5iZiI6MTcyMjI1ODE5MCwicGF0aCI6Ii8zODAwNzkvMzQ2NTE0NTk1LTEzNTcwMTZjLTM2NTAtNGI3MS04ZTlkLTFiNmY2NzE2MTdmZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyOVQxMzAzMTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04YTM1OTJkNzAxYzkxYTcyMTNmNjM5ZGM2M2U0YmM1NTBhMmVmOTMzYTc3YjhjMGIyZTRjNGM5OWU1MmE2ZDZiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.dZp7t3l7sDRDrJlbn5B7puWFE98oVq-uEWlA4OT_n9I>) >> that manage the command before it reaches the specific service handling the >> logic. >> >> - Should I leave them this way and just accept the new "Typed" stuff? >> - Should I change the actual logic and use different methods to >> reduce the code complexity ...etc? >> >> >> I would greatly appreciate any assistance or suggestions on how to >> enhance this flow by replacing these services. >> >> Thank you for your help! >> >> Best regards, >> Zeyad Nasef >> >> >>
