Hi fellow fineract devs,

I am writing in regards my PR: 
https://github.com/apache/fineract/pull/4057/files#r1762730334 

I have got a request to further enhance the original idea and rename the global 
configuration names to the following:
"As an extra thing, since we're using the name in the URL, I'd actually start 
restricting the global configuration names to a specific pattern. It must not 
start with - or _ but with a lowercase letter. Overall, the only characters 
allowed should be lowercase letters and -, _.And since these global config 
names are decided when developing, this validation should be part of the 
build/startup process.”

I was thinking on this request and considering we are planning to use the 
configuration name in the URI to identify the resource, I was wondering to go 
with something stricter and rename all the configurations to:
- lower case letters and only dash is allowed -> This one is easy
- cannot start with underscore or dash ->  we can have a validator for this 
which checks

The questions:

1. Would anyone mind these changes and adding these restrictions?
2. Should we have the validator that checks the proper naming conventions of 
configuration names at build / startup time? -> It would enforce to only have 
“proper” configuration names…
3. Should I rename only the global configuration entries that is part of the 
community version or should I write an update SQL that updates and renames all 
of them (if someone added a “custom” configuration entry, that shall be renamed 
as well)?

Thank you in advance,
Adam

> On 20 Sep 2024, at 04:13, James Dailey <jamespdai...@gmail.com> wrote:
> 
> +1 to this in particular:  
> 
> “Speaking up for the developers, there always should be an easy way to run 
> Fineract locally from our IDEs, without any additional tricking, without 
> packaging to docker or running a git server, running a spring cloud config 
> server, etc. “
> 
> A developer mode 
> 
> Vs 
> production mode
> 
> 
> 

Reply via email to