+1 Many times over
On Wed, Mar 5, 2025 at 11:41 AM Ádám Sághy <adamsa...@gmail.com> wrote: > Hi guys, > > Let me share some of my thoughts on a crucial part of any open source > application: the pull request > > The actual open pull requests of Fineract can be found here: > https://github.com/apache/fineract/pulls > > Time to time it worth to check them as: > > - This is a good exercise to review and validate the incoming PRs and > changes -> Get involved with Fineract > - A good way to keep up to date yourself with the changes and the work > of the community -> Get up to date with Fineract > - A good way to improve your understanding of Fineract and gain > visibility on the project -> Learn more about Fineract and its contributors > and maintainers > > > My recommendation would be: > > - Be involved by reviewing the pull requests! > - More eyes on the changes increase the quality and maybe you will > notice something that might have been missed without you! > > > Some of the key things to check: > > - The PR title and the commit message starts with: FINERACT-XXXX: > <short description> > - This story is an existing one: > http://issues.apache.org/jira/browse/FINERACT-XXXX > - The story and the PR relates to each other > - The PR is focusing on to solve 1 problem / feature > - Example of good PRs: > - PR title and content > - Remove unnecessary .toString() method calls from XYZ class > -> Focusing on 1 thing > - Remove unnecessary .toString() method calls from XYZ module > -> Focusing on 1 thing but wider scope > - Remove unnecessary .toString() method calls -> Focusing on > 1 thing but with the widest scope... if this does not involve way > too much > changes! > - Good to keep in mind: > - It should not contain too many changes! > - Tests are included, unless it is not needed (see above) > - Example of "bad" PRs: > - PR title and content > - Do some random refactor -> Doing various things and changes > many files in one PR > - Some changes -> Introducing a brand new feature but not > stated properly in the PR title and commit message > - Fixing LoanTransactionAPI -> However contains many changes > in various other classes, probably the PR trying to do more than > 1 thing > > > I hope this little summarisation helps to get better insight of Fineract > as open source software! > > Regards, > Adam >
