Adam Thanks for noticing this work. Here is some context:
The Peppersoup project with its many active contributors here have made an effort recently to go back to previously completed work 2022-2024 and to document that work in asciidocs. While there was some documentation in release notes and jira tickets, we hope that this will help in making the project more efficient and sustainable. A key one was the addition of Cucumber tests. Your help in adjusting it as you suggested would be appreciated. We want to make sure that future development is done on the main develop branch here, not on outside forks as we have seen many times. I believe that adequate and accurate documentation is a must have and should be part of any definition of done. You should probably make sure that your comments get to the dev specifically who made the documentation PR. Thanks On Tue, Oct 28, 2025 at 6:57 AM Adam Monsen <[email protected]> wrote: > new tests should use BDD/cucumber, not the old "integration" style, right? > Or does it just depend on what's being tested? If new tests should > always be BDD/cucumber, I'm thinking we should add something about that to > https://fineract.apache.org/docs/1.13.0/#_writing_integration_tests . > e.g. "Before writing a new integration test, consider creating a cucumber > test." > > https://fineract.apache.org/docs/1.13.0/#_testing should say something > about the test pyramid > <https://martinfowler.com/articles/practical-test-pyramid.html>, too. I > can start a new PR with followups to PR 5067 > <https://github.com/apache/fineract/pull/5067#issuecomment-3423007520>. > > I didn't even know PR 5067 happened, I just stumbled upon a ton of new > docs added re: E2E and integration tests. Looks pretty awesome so far! We > just need to true it up with followup work going on re: other doc updates > (continuing great work started in PR 5076 > <https://github.com/apache/fineract/pull/5076>). >
