Waiting for your PR in order to review it. Thank you in advance for your code contribution.
Regards Victor Romero El sáb, 27 dic 2025 a las 23:58, Monica (<[email protected]>) escribió: > Thank you for your guidance > Will keep it in mind. > > Regards > Monica > ------------------------------ > *From:* VICTOR MANUEL ROMERO RODRIGUEZ <[email protected]> > *Sent:* Saturday, December 27, 2025 18:42 > *To:* [email protected] <[email protected]> > *Subject:* Re: [FINERACT-2206] guidance on proposed backward-compatible > fix approach > > Hello, > > This is a one character typo. Just fix it and don’t maintain the typo. > > Regards > > > > El El sáb, 27 de dic de 2025 a la(s) 7:30 a.m., Monica < > [email protected]> escribió: > > Hello Fineract Maintainers, > I hope you’re doing well. > I’m planning to work on * FINERACT-2206* and wanted to confirm the > proposed approach with you before starting implementation, to ensure it > aligns with the project’s expectations and best practices. > Jira issue link: [FINERACT-2206] Rest API und code contain references to > the misspelled "allowPartialPeriodInterestCalcualtion" - ASF Jira > <https://issues.apache.org/jira/browse/FINERACT-2206> > Based on my understanding of the issue, the plan would be: > > 1. Identify all occurrences of the misspelled field > allowPartialPeriodInterestCalcualtion across the Java codebase and > REST API. > 2. Introduce the correctly spelled field > allowPartialPeriodInterestCalculation as the primary/internal > representation. > 3. Maintain backward compatibility for the REST API by supporting both > spellings (for example, using Jackson annotations such as @JsonAlias), > while favoring the correctly spelled version going forward. > 4. Update API documentation / OpenAPI specs to reflect the corrected > field name. > 5. Add or update tests to ensure both spellings are accepted and > existing clients are not broken. > 6. Mark the misspelled field as deprecated where appropriate. > > Before proceeding, I’d really appreciate your confirmation on: > > - Whether supporting * both spellings* for backward compatibility is > the preferred approach. > - Any specific guidelines or constraints you’d like me to follow while > implementing this fix. > > Once confirmed, I’ll go ahead and prepare a PR referencing * > FINERACT-2206*. > Thank you for your time and guidance. > Best regards, > Monica > >
