Hello Mónica, Your PR contains unrelated changes. Remove the changes and focus on the typo fix.
If you are a new to Java, my suggestion is to study and learn about this language, the errors are being printed in the console or in you IDE here you can look for the root cause of the issue. As a good practice you have to send the PR with 1 commit... "squash and commit" your changes. Regards Victor El jue., 1 de enero de 2026 4:06 a. m., Monica <[email protected]> escribió: > Hi all, > I have raised a PR for *FINERACT-2206*, where the primary change is > correcting the typo > allowPartialPeriodInterestCalcualtion → > allowPartialPeriodInterestCalculation across the REST API and related > code references. > PR link - https://github.com/apache/fineract/pull/5279 > The intent of this PR is strictly a typo correction to align the API and > codebase consistently. > However, I’m currently seeing *CI / E2E test failures* on this PR. I’ve > verified the changes locally, but I’m not fully sure if: > > - any tests are still referencing the old misspelled property, or > - there is an expected backward-compatibility consideration I may have > missed. > > I would really appreciate your guidance on: > > - whether additional changes are expected for backward compatibility, > or > - how these CI failures should be addressed for this type of typo-only > fix. > > Thank you for your time and support — looking forward to your suggestions. > Best regards, > Monica > > ------------------------------ > *From:* VICTOR MANUEL ROMERO RODRIGUEZ <[email protected]> > *Sent:* Monday, December 29, 2025 03:11 > *To:* [email protected] <[email protected]> > *Subject:* Re: [FINERACT-2206] guidance on proposed backward-compatible > fix approach > > Yes. 142 times in 35 files. > > If it passes the testing, the code review and also in the documents the PR > will go to the "develop" branch and in the future it could be included in a > release. > > Please share the PR for a technical/doc review. > > Regards > > Victor Romero > > El dom, 28 dic 2025 a las 19:05, Monica (<[email protected]>) > escribió: > > Hi Victor Romero, > Thanks for taking a look and for the clarification. I understand the point > about this being a single typo and will submit the PR shortly. > However, while digging deeper, I noticed that this typo ( > allowPartialPeriodInterestCalcualtion) is currently propagated across > multiple layers — domain models, API parameters, constants, SQL aliases, > Swagger docs, legacy HTML docs, and even integration/e2e tests. Because of > that, it seems to have effectively become part of the public API and > persisted contract. > My concern is that directly fixing the spelling everywhere might > unintentionally break existing clients or integrations that are already > using the misspelled field name. From that perspective, I was wondering > whether it would be safer to handle this in a backward-compatible way (for > example, supporting both the old and corrected parameter names, with > deprecation guidance). > I wanted to check with you before proceeding further, to make sure the > approach aligns with the project’s expectations and avoids any regressions > for existing users. > Happy to follow whatever direction you feel is best here — just wanted to > raise this before making changes. > Thanks again for your guidance, > Monica > > ------------------------------ > *From:* VICTOR MANUEL ROMERO RODRIGUEZ <[email protected]> > *Sent:* Sunday, December 28, 2025 15:51 > *To:* [email protected] <[email protected]> > *Subject:* Re: [FINERACT-2206] guidance on proposed backward-compatible > fix approach > > Waiting for your PR in order to review it. > > Thank you in advance for your code contribution. > > Regards > > Victor Romero > > El sáb, 27 dic 2025 a las 23:58, Monica (<[email protected]>) > escribió: > > Thank you for your guidance > Will keep it in mind. > > Regards > Monica > ------------------------------ > *From:* VICTOR MANUEL ROMERO RODRIGUEZ <[email protected]> > *Sent:* Saturday, December 27, 2025 18:42 > *To:* [email protected] <[email protected]> > *Subject:* Re: [FINERACT-2206] guidance on proposed backward-compatible > fix approach > > Hello, > > This is a one character typo. Just fix it and don’t maintain the typo. > > Regards > > > > El El sáb, 27 de dic de 2025 a la(s) 7:30 a.m., Monica < > [email protected]> escribió: > > Hello Fineract Maintainers, > I hope you’re doing well. > I’m planning to work on * FINERACT-2206* and wanted to confirm the > proposed approach with you before starting implementation, to ensure it > aligns with the project’s expectations and best practices. > Jira issue link: [FINERACT-2206] Rest API und code contain references to > the misspelled "allowPartialPeriodInterestCalcualtion" - ASF Jira > <https://issues.apache.org/jira/browse/FINERACT-2206> > Based on my understanding of the issue, the plan would be: > > 1. Identify all occurrences of the misspelled field > allowPartialPeriodInterestCalcualtion across the Java codebase and > REST API. > 2. Introduce the correctly spelled field > allowPartialPeriodInterestCalculation as the primary/internal > representation. > 3. Maintain backward compatibility for the REST API by supporting both > spellings (for example, using Jackson annotations such as @JsonAlias), > while favoring the correctly spelled version going forward. > 4. Update API documentation / OpenAPI specs to reflect the corrected > field name. > 5. Add or update tests to ensure both spellings are accepted and > existing clients are not broken. > 6. Mark the misspelled field as deprecated where appropriate. > > Before proceeding, I’d really appreciate your confirmation on: > > - Whether supporting * both spellings* for backward compatibility is > the preferred approach. > - Any specific guidelines or constraints you’d like me to follow while > implementing this fix. > > Once confirmed, I’ll go ahead and prepare a PR referencing * > FINERACT-2206*. > Thank you for your time and guidance. > Best regards, > Monica > >
