Hi Tofunmi, Great initiative.
Let me share my experience, mostly from the loan module. I'm a big fan of unit tests — they're really useful when they cover relevant logic. However, in this project, where we have a lot of DTOs, entities, and complex flows, I've found integration and e2e tests to be more meaningful in practice. I'm not saying unit tests are irrelevant, or that the accounting module necessarily works the same way, but I'd suggest also considering integration/e2e tests for the key flows, and being selective about what you cover with unit tests — focusing on non-trivial logic rather than boilerplate. Increasing test coverage is great — let's make sure we do it with tests that give us real confidence. Best regards, Attila Tofunmi Oguntibeju <[email protected]> ezt írta (időpont: 2026. ápr. 3., P, 18:32): > Sure. Will do > > On Fri, 3 Apr 2026 at 5:19 PM, James Dailey <[email protected]> wrote: > >> Please consult the test framework discussions on the list previously. Do >> a search on the archives for insights. >> >> Then also see the work on client-feign and the gherkin tests. >> >> We’ve deprecated some testing approaches in favor of cucumber (gherkin). >> End2End >> >> >> >> Sent from Gmail Mobile >> >> >> On Fri, Apr 3, 2026 at 9:16 AM James Dailey <[email protected]> wrote: >> >>> Excellent! >>> >>> >>> On Fri, Apr 3, 2026 at 3:13 AM Tofunmi Oguntibeju < >>> [email protected]> wrote: >>> >>>> Hi everyone, >>>> >>>> I hope you're doing well. >>>> >>>> As part of my ongoing contributions to Apache Fineract, I’ve been >>>> reviewing the accounting module and noticed that it currently lacks a >>>> dedicated test suite compared to other parts of the codebase. >>>> >>>> To improve reliability and maintainability, I plan to start introducing >>>> test coverage for this module. The approach will focus on: >>>> >>>> - Unit tests for core accounting domain logic >>>> - Validation and exception scenarios >>>> - Incremental improvements to overall coverage without disrupting >>>> existing functionality >>>> >>>> I’ll begin with small, self-contained tests and expand gradually to >>>> ensure consistency with existing testing patterns in the project. >>>> >>>> Before proceeding further, I’d appreciate any guidance from the >>>> community on: >>>> >>>> - Whether there is any ongoing work or prior effort around adding >>>> tests to the accounting module >>>> - Areas where additional testing would provide the most value >>>> >>>> My goal is to strengthen confidence in the accounting module and >>>> contribute to the long-term quality of the codebase. >>>> >>>> Looking forward to your feedback. >>>> >>>> Best regards, >>>> Tofunmi Oguntibeju >>>> >>>
