Hi Adam, I'd like to work on FINERACT-3148, FINERACT-3151 and FINERACT-3150. 3150 changes the same class as 3148, so I'll start it after the 3148 PR is merged. My Jira account request is pending; I'll comment on the tickets once it's approved.
Regarding 3148: around 23 private helpers in LoanWritePlatformServiceJpaRepositoryImpl (loan counters, notes, schedule archive, saveAndFlushLoanWithDataIntegrityViolationChecks,...) are used by both the disbursement methods and other operations. Is it fine to move them into a small shared component that both services use, or should 3148 move only the disbursement methods and their own helpers and leave the shared ones for 3150? Also, bulkLoanDisbursal calls disburseLoan but isn't in the ticket's list. I'd move it with the other disbursement methods unless you'd rather keep it where it is. Thanks, Samarth Deshpande
