Hi,

My 2 cents:
- If we are deciding to remove the “changes” field, we should aim to do it on 
all endpoints.

- Before we remove it, it would be good to know whether anybody relies on it in 
the first place.
- In my understanding, the changes field was never maintained consistently, and 
some changed fields were added, some were not…

I would recommend marking all of them as deprecated (step 1) and removing them 
on a one-by-one basis (or maybe all of them in one shot… open for discussing 
any strategies)

Regards,
Adam S


> On Nov 18, 2026, at 10:38 AM, Dhroov Sankla <[email protected]> 
> wrote:
> 
> Hi Ádám,
> 
> Apologies for any confusion—this is strictly about the `"changes"` wrapper 
> map (`getChanges()`) on `CurrencyUpdateResponse` (used only by `PUT 
> /v1/currencies`), not `"charges"`[cite: 6, 10].
> 
> To answer your questions directly:
> 
> 1. Reason for removal:
>    `CurrencyUpdateResponse#getChanges()` was marked `@Deprecated(forRemoval = 
> true)` back in Fineract 1.15.0 alongside a TODO note to eliminate raw 
> `Map<String, Object>` response wrappers in favor of the strongly-typed 
> `currencies` list (`List<String>`)
> 
> 2. Scope of change:
>    No, this PR only removes `getChanges()` from `CurrencyUpdateResponse` 
> (`PUT /v1/currencies`).It does not touch other endpoints.
> 
> 3. Community feedback:
>    That is exactly why Arnold suggested bringing it to the dev list before 
> merging PR #6804. If downstream users still rely on `changes.currencies` or 
> if the community prefers keeping it until a broader deprecation cleanup, we 
> can hold off or close the PR.
> 
> 
> 
> On Wed, Nov 18, 2026 at 3:58 PM Ádám Sághy <[email protected] 
> <mailto:[email protected]>> wrote:
>> Hi  
>> 
>> Thank you for bringing this up.  
>> 
>> I would like more detail on the following:  
>> - What is the reason for removing the “charges” field?  
>> - Is the plan to drop this field from every endpoint’s output?  
>> - Are Fineract users satisfied with this?  
>> 
>> The change may be acceptable, yet I do not recall such decision was 
>> discussed by community.
>> 
>> Regards,  
>> Adam S
>> 
>> Sent from my iPhone
>> 
>>> On 18 Nov 2026, at 10:20, Dhroov Sankla <[email protected] 
>>> <mailto:[email protected]>> wrote:
>>> 
>>> 
>>> Hi everyone,
>>> 
>>> As discussed during review with Ádám Sághy and Arnold Galovics on PR #6804 
>>> (FINERACT-3028), we are removing the `@Deprecated(forRemoval = true)` 
>>> `getChanges()` method from `CurrencyUpdateResponse` (deprecated since 
>>> 1.15.0)
>>> 
>>> Impact:
>>> The `PUT /v1/currencies` endpoint will no longer return the legacy 
>>> `"changes": { "currencies": [...] }` wrapper in its JSON response payload. 
>>> External clients should read the top-level `"currencies"` array directly.
>>> 
>>> Jira: Jira Link <https://issues.apache.org/jira/browse/FINERACT-3028>
>>> PR: GH PR Link <https://github.com/apache/fineract/pull/6804>
>>> 
>>> Please let us know on the PR or this thread if there are any concerns 
>>> before merging
>>> 
>>> Best regards,
>>> Dhroov Sankla

Reply via email to