Hi Markus, I think I agree with Keith on this one, mainly because it seems like we are only replacing to satisfy the licensing requirements, while we already know most implementations will be using either MariaDB or MySQL connector. I can see that it's nice to have it part of the package, but is referencing it in a gradle dependency in breach with the license?
Sander Sander van der Heyden CTO Musoni Services Mobile (NL): +31 (0)6 14239505 Mobile (Kenya): +254 (0)707211284 Skype: s.vdheyden Website: musonisystem.com Follow us on Twitter! <https://twitter.com/musonimfi> Postal address: Hillegomstraat 12-14, office 1.11, 1058 LS, Amsterdam, The Netherlands On Mon, Feb 8, 2016 at 1:19 PM, Markus Geiß <markus.ge...@live.de> wrote: > Integration tests are part of our current work too and they need to run > with a > JDBC driver ... > > Aside from that I agree that we may can ommit a driver from our source > release. > > If this is the case could one of our mentors weigh in and let us know if > it is > compliant with the license policies to use a non-compliant library in a > test > environment. If this is the case, it would also fix our Hibernate issue, > but prevent > us from releasing a binary/distribution. > > Best, > > Markus > > .::YAGNI likes a DRY KISS::. > > > Date: Mon, 8 Feb 2016 12:15:11 +0000 > > Subject: Re: [GitHub] incubator-fineract pull request: Connector changes > from mysql to d... > > From: keithwoodl...@gmail.com > > To: dev@fineract.incubator.apache.org > > > > Markus, > > > > Yes - I still feel if you just ommited the connector from any release and > > updated installation instructions you wouldnt have to make any code > changes > > or do any testing - Having the platform supported and tested agaisnt the > > Drizzle Driver isnt that useful I would of thought. > > > > Keith. > > > > On Mon, Feb 8, 2016 at 12:12 PM, Markus Geiß <markus.ge...@live.de> > wrote: > > > > > Good point! > > > > > > Let me create an issue ... we may face something similar with > Hibernate. > > > > > > Best, > > > > > > Markus > > > > > > .::YAGNI likes a DRY KISS::. > > > > > > > Date: Mon, 8 Feb 2016 12:11:28 +0000 > > > > Subject: Re: [GitHub] incubator-fineract pull request: Connector > changes > > > from mysql to d... > > > > From: keithwoodl...@gmail.com > > > > To: dev@fineract.incubator.apache.org > > > > > > > > Markus, > > > > > > > > Yes Markus, you should be able to do that. > > > > > > > > I dont see an apache fineract issue (to watch) for this work but if > you > > > let > > > > me know when its finished I'd be happy to give a go at going through > the > > > > (production/test) installation instructions. > > > > > > > > Keith. > > > > > > > > On Mon, Feb 8, 2016 at 12:00 PM, Markus Geiß <markus.ge...@live.de> > > > wrote: > > > > > > > > > The whole Core Team including our QA and Support will do testing > the > > > > > next few days to ensure all is working. > > > > > > > > > > I'm also not happy with it, given the huge test effort we have, > but it > > > > > would always > > > > > be feasible to replace the default driver with anything you like > to use > > > > > for your > > > > > 'distribution'. ; o) > > > > > > > > > > Best, > > > > > > > > > > Markus > > > > > > > > > > .::YAGNI likes a DRY KISS::. > > > > > > > > > > > Date: Mon, 8 Feb 2016 11:51:13 +0000 > > > > > > Subject: Re: [GitHub] incubator-fineract pull request: Connector > > > changes > > > > > from mysql to d... > > > > > > From: keithwoodl...@gmail.com > > > > > > To: dev@fineract.incubator.apache.org > > > > > > > > > > > > Hi Markus, > > > > > > > > > > > > Thats pretty frustrating. Did you consider retaining mysql > > > connector/j > > > > > > driver to use for development / testing and excluding from > release > > > > > > artifact. It would become one of the installation instructions to > > > > > download > > > > > > the driver then to use the software. > > > > > > > > > > > > I only say this because there might be alot of risk with using > > > Drizzle > > > > > JDBC > > > > > > Driver for use with MySQL. You will have to do extensive testing > to > > > > > ensure > > > > > > it works out of the box in the same way as the mysql connector j > one > > > > > (and I > > > > > > doubt it does) i.e. does it support all types of SQL queries > queries > > > that > > > > > > use temp tables etc Is it even still under active development? > > > > > > > > > > > > Keith. > > > > > > > > > > > > On Mon, Feb 8, 2016 at 11:27 AM, Markus Geiß < > markus.ge...@live.de> > > > > > wrote: > > > > > > > > > > > > > Hey Keith, > > > > > > > > > > > > > > the change was necessary to fulfill the license policies. Both > > > > > Connector/J > > > > > > > and > > > > > > > the Maria DB driver are licensed under LGPL 2.1 and are not > > > compatible > > > > > with > > > > > > > Apache's policies. Drizzle is one of the only fits. > > > > > > > > > > > > > > Best, > > > > > > > > > > > > > > Markus > > > > > > > > > > > > > > .::YAGNI likes a DRY KISS::. > > > > > > > > > > > > > > > Date: Mon, 8 Feb 2016 09:17:37 +0000 > > > > > > > > Subject: Re: [GitHub] incubator-fineract pull request: > Connector > > > > > changes > > > > > > > from mysql to d... > > > > > > > > From: keithwoodl...@gmail.com > > > > > > > > To: dev@fineract.incubator.apache.org > > > > > > > > > > > > > > > > Just curious about this change from the MySQL Connector/J > Driver > > > to > > > > > > > Drizzle > > > > > > > > Driver > > > > > > > > > > > > > > > > 1) Why did this need to change? Was it for license reasons? > > > > > > > > > > > > > > > > 2) Why choose the Drizzle Driver? Why not choose MariaDB > Driver > > > > > instead? > > > > > > > > > > > > > > > > Keith. > > > > > > > > > > > > > > > > On Mon, Feb 8, 2016 at 8:13 AM, asfgit <g...@git.apache.org> > > > wrote: > > > > > > > > > > > > > > > > > Github user asfgit closed the pull request at: > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-fineract/pull/4 > > > > > > > > > > > > > > > > > > > > > > > > > > > --- > > > > > > > > > If your project is set up for it, you can reply to this > email > > > and > > > > > have > > > > > > > your > > > > > > > > > reply appear on GitHub as well. If your project does not > have > > > this > > > > > > > feature > > > > > > > > > enabled and wishes so, or if the feature is enabled but not > > > > > working, > > > > > > > please > > > > > > > > > contact infrastructure at infrastruct...@apache.org or > file a > > > JIRA > > > > > > > ticket > > > > > > > > > with INFRA. > > > > > > > > > --- > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
