[GitHub] incubator-fineract pull request: Loan Product Office Name Paramete...

[anuragmath]

Github user anuragmath commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/65#discussion_r59515825
  
    --- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/AccountNumberGenerator.java
 ---
    @@ -62,6 +63,7 @@ public String generate(Loan loan, AccountNumberFormat 
accountNumberFormat) {
             propertyMap.put(ID, loan.getId().toString());
             propertyMap.put(OFFICE_NAME, loan.getOffice().getName());
             propertyMap.put(LOAN_PRODUCT_SHORT_NAME, 
loan.loanProduct().getShortName());
    +        propertyMap.put(OFFICE_AND_LOAD_PRODUCT_NAME, 
loan.getOffice().getName()+ loan.loanProduct().getShortName());
    --- End diff --
    
    thanks for pointing out that. I have corrected it and made it necessary now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---