Github user nikpawar89 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/70#discussion_r59668493
  
    --- Diff: 
fineract-provider/src/main/java/org/apache/fineract/useradministration/api/UsersApiResource.java
 ---
    @@ -140,30 +148,45 @@ public String create(final String 
apiRequestBodyAsJson) {
             return this.toApiJsonSerializer.serialize(result);
         }
     
    -    @PUT
    -    @Path("{userId}")
    -    public String update(@PathParam("userId") final Long userId, final 
String apiRequestBodyAsJson) {
    -
    -        final CommandWrapper commandRequest = new CommandWrapperBuilder() 
//
    -                .updateUser(userId) //
    -                .withJson(apiRequestBodyAsJson) //
    -                .build();
    -
    -        final CommandProcessingResult result = 
this.commandsSourceWritePlatformService.logCommandSource(commandRequest);
    -
    -        return this.toApiJsonSerializer.serialize(result);
    +  @PUT
    +  @Path("/{userId}/usrnme/{usrnme}/currentPass/{currentPass}")
    --- End diff --
    
    After implementing this code, I did few tests to change the user details. 
Nothing accept 'updatepassword case' was asked password. For now I have just 
proposed the change, there are still vulnerabilities in this approach which I 
discovered later. I am going to Fix them and would come back later. Thanks for 
the feedback


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to