I have provided high level comments on the PR. PR cannot be taken in as is.
I will ask the fellow community members to provide more comments on the core part of the solution. Regards, Adi From: Ed Cable [mailto:edca...@mifos.org] Sent: 11 May 2016 03:58 To: dev@fineract.incubator.apache.org; Adi Raju <adi.r...@confluxtechnologies.com> Cc: James Rowe <jrowe...@gmail.com>; Austin H <aus...@haedrian.io>; Nathan McClellan <nat...@mentorsinternational.org> Subject: Review of Pull Request from James Rowe Hi Fineract devs, I wanted to make sure you saw the incoming pull request from James Rowe. It's a fix for holidays that's needed by customer of theirs in the Philippines that is needed in the latest stable release. Adi, this will ultimately be something we'll need to ensure is in our Mifos X distribution of Fineract. Ed -- Ed Cable Director of Community Programs, Mifos Initiative edca...@mifos.org <https://web.chilipiper.com/link/mifos.org/57325ffae4b02bbec5bc5b8b?link=bWFpbHRvJTNBZWRjYWJsZSU0MG1pZm9zLm9yZw==> | Skype: edcable | Mobile: +1.484.477.8649 Collectively Creating a World of 3 Billion Maries | http://mifos.org <https://web.chilipiper.com/link/mifos.org/57325ffae4b02bbec5bc5b8b?link=aHR0cCUzQSUyRiUyRm1pZm9zLm9yZw==> <https://web.chilipiper.com/link/mifos.org/57325ffae4b02bbec5bc5b8b?link=aHR0cCUzQSUyRiUyRmZhY2Vib29rLmNvbSUyRm1pZm9z> <https://web.chilipiper.com/link/mifos.org/57325ffae4b02bbec5bc5b8b?link=aHR0cCUzQSUyRiUyRnd3dy50d2l0dGVyLmNvbSUyRm1pZm9z> <https://web.chilipiper.com/track/mifos.org/57325ffae4b02bbec5bc5b8b.png>
