I'm voting +0 on this release: Here's what I checked: Notice file: looks good License file: contains a reference to a license file (glyphicons.MIT) which is not present under licenses. Also, I learned recently from Justin's example project 1) that the version of the bundled project should be included since sometimes licenses change from one version to the next. Signature: Is signed with an apache e-mail address associated key, but I was unable to verify the fingerprint with Nazeer. Buildable: works according to instructions in README
I was unable to verify that the integration tests work according to the instructions, because I'm having problems with my installation of mysql, but I'm willing to assume the best. If we can fix the minor license file issues (add versions and add glyphicons.MIT to licenses, and if I can verify the signature with Nazeer, I'll change my vote to a +1. Greets from the Voreifel, Germany, Myrle 1.) https://github.com/justinmclean/ApacheWombat/blob/master/LICENSE *Myrle Krantz* Solutions Architect RɅĐɅЯ, The Mifos Initiative mkra...@mifos.org | Skype: mkrantz.mifos.org | http://mifos.org <http://facebook.com/mifos> <http://www.twitter.com/mifos> On Wed, Jul 6, 2016 at 7:19 PM, Nazeer Shaik < nazeer.sh...@confluxtechnologies.com> wrote: > Thank you Markus. I have addressed the issue and updated release files. > > The new commit to be voted is: > > https://git-wip-us.apache.org/repos/asf?p=incubator-fineract.git;a=commit;h=a62620811975f88e9741732c3cb04838dc44b634 > > *Source Files:* > https://dist.apache.org/repos/dist/dev/incubator/fineract/0.3.1-incubating/ > > *All, can you please review and vote again by July 07, 2016 @ 6pm PST.* > > Thanks, > Nazeer > > On Wed, Jul 6, 2016 at 2:44 PM, Markus Geiß <markus.ge...@live.de> wrote: > > > -1 Still some UI related licenses packaged ... > > > > -----Ursprüngliche Nachricht----- > > Von: Nazeer Shaik [mailto:nazeer1100...@apache.org] > > Gesendet: Freitag, 1. Juli 2016 08:47 > > An: dev@fineract.incubator.apache.org > > Betreff: [VOTE] [FINERACT] 0.3.1-incubating for release > > > > Hello Fineract community, > > > > We have created a 0.3.1-incubating release, with the artifacts below up > > for a vote. > > > > This is the 1st release for Apache Fineract (incubating). > > > > There are two main goals of this release: > > > > - Clear all license issues in the code base and make it legally ready > to > > be adopted by the community. > > > > > > - Share the new features that have been developed so far, in order to > > give the community a good sense of the upcoming 0.3.1 release. > > > > > > *For more information including release notes, please see:* > > > https://cwiki.apache.org/confluence/display/FINERACT/0.3.1+Release-+Apache+Fineract > > > > This is a *source code tar ball* only release. > > > > *** Please download, review and vote by Mon July 05, 2016 @ 6pm PST *** > > > > *Source Files:* > > > https://dist.apache.org/repos/dist/dev/incubator/fineract/0.3.1-incubating/ > > > > *Commit to be voted on:* > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-fineract.git;a=commit;h=1c2aa1980ea59b8decf5d954f74566fb393cda5f > > > > *Build verification steps can be found at: * Refer 'README.md' in > > apache-fineract-0.3.1-incubating-src.tar.gz > > > > *KEYS file containing PGP Keys we use to sign the release:* > > https://dist.apache.org/repos/dist/dev/incubator/fineract/KEYS > > > > > > *Note: * > > > > - This is a source only release with no binaries, with instructions on > > how to build/test the application. > > > > > > - We use hibernate for integration tests only and doesn't include any > > source or binary from Hibernate > > > > To help in tallying the vote, members please be sure to indicate > > "(binding)" with your vote. > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove (and reason why) > > > > Thank you, > > Nazeer > > >
