[jira] [Commented] (FINERACT-54) Add ability to delete code values by setting a flag (is_active) to 0

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FINERACT-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405780#comment-15405780
 ] 

ASF GitHub Bot commented on FINERACT-54:
----------------------------------------

Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/192#discussion_r73325637
  
    --- Diff: 
fineract-provider/src/main/java/org/apache/fineract/infrastructure/codes/api/CodeValuesApiResource.java
 ---
    @@ -86,11 +88,16 @@ public CodeValuesApiResource(final 
PlatformSecurityContext context, final CodeVa
         @GET
         @Consumes({ MediaType.APPLICATION_JSON })
         @Produces({ MediaType.APPLICATION_JSON })
    -    public String retrieveAllCodeValues(@Context final UriInfo uriInfo, 
@PathParam("codeId") final Long codeId) {
    +    public String retrieveAllCodeValues(@Context final UriInfo uriInfo, 
@PathParam("codeId") final Long codeId, 
    +            @QueryParam("includeDeletedCodeValues") final String 
includeDeletedCodeValues) {
     
             
this.context.authenticatedUser().validateHasReadPermission(this.resourceNameForPermissions);
     
    -        final Collection<CodeValueData> codeValues = 
this.readPlatformService.retrieveAllCodeValues(codeId);
    +        Collection<CodeValueData> codeValues = 
this.readPlatformService.retrieveAllActiveCodeValues(codeId);
    --- End diff --
    
    avoid multiple DB calls when includeDeletedCodeValues is true 


> Add ability to delete code values by setting a flag (is_active) to 0
> --------------------------------------------------------------------
>
>                 Key: FINERACT-54
>                 URL: https://issues.apache.org/jira/browse/FINERACT-54
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Emmanuel Nnaa
>            Assignee: Markus Geiss
>            Priority: Minor
>
> Delete a code value by setting the "is_active" property to 0, thus avoiding 
> "DataIntegrityViolationException".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)