[
https://issues.apache.org/jira/browse/FINERACT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418347#comment-15418347
]
ASF GitHub Bot commented on FINERACT-72:
----------------------------------------
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/199#discussion_r74540135
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccountingProcessorHelper.java
---
@@ -820,11 +820,12 @@ private void createCreditJournalEntryForSavings(final
Office office, final Strin
SavingsAccountTransaction savingsAccountTransaction = null;
ClientTransaction clientTransaction = null;
final Long shareTransactionId = null;
- final PaymentDetail paymentDetail = null;
+ PaymentDetail paymentDetail = null;
String modifiedTransactionId = transactionId;
if (StringUtils.isNumeric(transactionId)) {
long id = Long.parseLong(transactionId);
savingsAccountTransaction =
this.savingsAccountTransactionRepository.findOne(id);
+ paymentDetail =
this.savingsAccountTransactionRepository.findOne(id).getPaymentDetail();
--- End diff --
unnecessary repository call. You can make use of savingsAccountTransaction
object to retrieve payment details
> Speed up the retrieval of journal entries when "transactionDetails" is set to
> true
> ----------------------------------------------------------------------------------
>
> Key: FINERACT-72
> URL: https://issues.apache.org/jira/browse/FINERACT-72
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Emmanuel Nnaa
> Assignee: Markus Geiss
>
> It takes a little over 3 minutes to retrieve about 360 journal entries if the
> "transactionDetails" parameter is set to true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
