ASF GitHub Bot commented on FINERACT-37:

Github user terencemo commented on a diff in the pull request:

    --- Diff: 
    @@ -96,10 +96,33 @@ public LocalDate generateNextRepaymentDate(final 
LocalDate lastRepaymentDate, fi
    +        if (currentCalendar == null && 
holidayDetailDTO.getWorkingDays().getExtendTermForRepaymentsOnHolidays()) {
    --- End diff --
    Tried calling adjustRepaymentDate. It doesn't reschedule for holidays other 
than weekend. Went through the code of adjustRepaymentDate and found nothing 
that handles holidays. The code block after the if does something which I 
couldn't find in any existing function in the codebase.

> Support rescheduling repayments on holidays
> -------------------------------------------
>                 Key: FINERACT-37
>                 URL: https://issues.apache.org/jira/browse/FINERACT-37
>             Project: Apache Fineract
>          Issue Type: Improvement
>          Components: System
>            Reporter: James Rowe
>            Assignee: Markus Geiss
> Our client is currently trying to migrate from their current financial 
> software, but one of the configuration options is not present in Fineract. 
> The option changes the way Fineract schedules loan repayments. Instead of 
> rescheduling a repayment to a different day in the week, holidays would 
> reschedule the repayment to the next due date and extend the schedule. For 
> example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that 
> has a repayment fall in the holiday will be rescheduled to the next week and 
> the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png 
> With this the loan term is extended and the repayment that landed on a 
> holiday is repaid on the next due date. 
> I already have a proof of concept patch for this, but I think there are some 
> issues with it. As such, I would like to work with a developer to discuss the 
> best way to implement this, or if you would like, we can just figure out why 
> my patch occasionally enters an infinite loop...
> As a related request, the client is looking to have the interest due at this 
> repayment to be redistributed across the full loan schedule. I wasn't sure if 
> I should include this in this issue report or to make a new one that is 
> related to this issue.

This message was sent by Atlassian JIRA

Reply via email to