Hey Nayan, I've sent a pull request with the needed changes.
Cheers Markus -----Original Message----- From: Markus Geiß [mailto:mge...@mifos.org] Sent: Thursday, November 17, 2016 08:43 PM To: Ed Cable <edca...@mifos.org> Cc: dev@fineract.incubator.apache.org; Santosh Math <sant...@confluxtechnologies.com>; Nayan Ambali <na...@confluxtechnologies.com> Subject: Re: [Mifos-developer] [Need help] Refernce UI and FS document for survey framework APIs Hey Nayan, sorry ... somehow your mail slipped through. I'll take care about needed changes. and will provide a fix until early next week. Best wishes, Markus Geiss Chief Architect RɅĐɅЯ, The Mifos Initiative On Nov 17, 2016 19:29, "Ed Cable" <edca...@mifos.org> wrote: > Markus, > > Are you able to respond to Nayan's comments? > > Santosh, let's please add this to the queue of code that needs to be > tested. > > Nayan - how is your work on the surveys UI coming along? I plan on > having one of our product management volunteers work with Mentors > International to scope out the UI they'd like to see for the surveys. > > Ed > > On Wed, Oct 5, 2016 at 8:36 AM, Nayan Ambali <nayan.amb...@gmail.com> > wrote: > >> Markus, >> >> I have few doubts w.r.t. SPM APIs, >> >> 1. Score card list always sends empty result (GET: >> /surveys/{surveyId}/scorecards) >> >> Looking at code (Github link, dev branch >> <https://github.com/apache/incubator-fineract/blob/develop/ >> fineract-provider/src/main/java/org/apache/fineract/spm/ >> api/ScorecardApiResource.java> >> ) >> if (scorecards == null) { >> return ScorecardMapper.map(scorecards); } >> >> return Collections.EMPTY_LIST; >> >> it always return empty collections. >> >> If you confirm, I will fix and send the code back to community >> >> 2. Score card for client is also always sends empty result [ *GET*: >> /surveys/{surveyId}/scorecards/clients/{clientId}") ] Looking at code >> (Github link, dev branch >> <https://github.com/apache/incubator-fineract/blob/develop/ >> fineract-provider/src/main/java/org/apache/fineract/spm/ >> api/ScorecardApiResource.java> >> ) >> if (scorecards == null) { >> return ScorecardMapper.map(scorecards); >> } >> return Collections.EMPTY_LIST; >> >> If you confirm the issue is because of above code, I will fix it and >> send the code back to community >> >> 3. Submitting survey also does not work It gives database contraint >> voilation, after looking into deep, >> *m_survey_scorecards* table has foreign key relation with not >> existing table. >> >> If you confirm the issue is because of wrong db constraint, I will >> fix it and send the code back to community >> >> >> 4. After fixing the 3 point, a survey can be submitted many time and >> not able to track which is the latest version from scorecard data. >> How do I get the latest version of response? >> >> I am not regular developer, please correct me if am wrong in any of >> the above analysis. >> >> @Ed, >> Does any institute using SPM module? I want to understand how it is >> used by the end user. any pointers towards will help a lot. >> >> >> - >> Nayan Ambali >> >> >> >> >> >> >> >> On Wed, 5 Oct 2016 at 11:26 Gaurav Saini <gauravsain...@gmail.com> wrote: >> >> > Hello Nayan, >> > >> > All the code related to survey is in develop branch. Below are the >> > path >> of >> > the files: >> > >> > app/scripts/controllers/client/SurveyController.js >> > app/views/clients/survey.html >> > >> > Thanks >> > Gaurav >> > >> > Sent with Mailtrack >> > < >> > https://mailtrack.io/install?source=signature&lang=en&referr >> al=gauravsain...@gmail.com&idSignature=22 >> > > >> > >> > On Wed, Oct 5, 2016 at 11:19 AM, Nayan Ambali >> > <nayan.amb...@gmail.com> >> > wrote: >> > >> > > Thanks Markus link is useful to me. >> > > >> > > @Gaurav, can I get that UI code? >> > > >> > > - >> > > Nayan Ambali >> > > >> > > >> > > On Tue, 4 Oct 2016 at 17:17 Markus Geiß <mge...@mifos.org> wrote: >> > > >> > > > Hey Nayan, >> > > > >> > > > here you can find the concept docu: >> > > > >> > > > >> > > > https://mifosforge.jira.com/wiki/display/MIFOSX/Social+ >> > > Performance+Management+Framework >> > > > >> > > > Best wishes, >> > > > >> > > > Markus Geiss >> > > > Chief Architect >> > > > RɅĐɅЯ, The Mifos Initiative >> > > > >> > > > On Oct 4, 2016 10:09, "Gaurav Saini" <gauravsain...@gmail.com> >> wrote: >> > > > >> > > > Hello Nayan, >> > > > >> > > > I have worked on the Survey UI a while back and its inside the code. >> > > > Actually, I didn't have any mockups with me just designed it >> directly >> > > > according to how the data is coming from APIs. >> > > > I think you can design and develop on top of that, code is in >> develop >> > > > branch for survey. >> > > > >> > > > Thanks >> > > > Gaurav >> > > > >> > > > Sent with Mailtrack >> > > > < >> > > > https://mailtrack.io/install?source=signature&lang=en&; >> > > referral=gauravsain...@gmail.com&idSignature=22 >> > > > > >> > > > >> > > > On Tue, Oct 4, 2016 at 1:23 PM, Ed Cable <edca...@mifos.org> wrote: >> > > > >> > > > > Markus, >> > > > > >> > > > > Can you help Nayan when you get the chance? Gaurav - can you >> > > > > point >> > > Nayan >> > > > > anywhere? >> > > > > >> > > > > Ed >> > > > > >> > > > > On Sat, Oct 1, 2016 at 10:26 PM, Nayan Ambali < >> > nayan.amb...@gmail.com> >> > > > > wrote: >> > > > > >> > > > >> Dear Community, >> > > > >> >> > > > >> I need to develop user interface for SPM, I see API >> > > > >> available for >> > the >> > > > >> same in API documentation. Do we have reference UI or UI >> > > > >> mock-ups >> > and >> > > > >> functional specification document for the SPM/Survey. >> > > > >> >> > > > >> - >> > > > >> Nayan Ambali >> > > > >> >> > > > >> >> > > > >> ------------------------------------------------------------ >> > > > >> ------------------ >> > > > >> Check out the vibrant tech community on one of the world's >> > > > >> most engaging tech sites, SlashDot.org! >> > > > >> http://sdm.link/slashdot Mifos-developer mailing list >> > > > >> mifos-develo...@lists.sourceforge.net >> > > > >> Unsubscribe or change settings at: >> > > > >> https://lists.sourceforge.net/lists/listinfo/mifos-developer >> > > > >> >> > > > > >> > > > > >> > > > > >> > > > > -- >> > > > > *Ed Cable* >> > > > > Director of Community Programs, Mifos Initiative >> > > > > edca...@mifos.org | Skype: edcable | Mobile: +1.484.477.8649 >> > <+1%20484-477-8649> >> > > > <+1%20484-477-8649> >> > > > > >> > > > > *Collectively Creating a World of 3 Billion Maries | * >> > http://mifos.org >> > > > > <http://facebook.com/mifos> <http://www.twitter.com/mifos> >> > > > > >> > > > > >> > > > >> > > > >> > > > -- >> > > > Regards, >> > > > *Gaurav Saini* >> > > > >> > > >> > >> > >> > >> > -- >> > Regards, >> > *Gaurav Saini* >> > >> > > > > -- > *Ed Cable* > Director of Community Programs, Mifos Initiative edca...@mifos.org | > Skype: edcable | Mobile: +1.484.477.8649 > > *Collectively Creating a World of 3 Billion Maries | *http://mifos.org > <http://facebook.com/mifos> <http://www.twitter.com/mifos> > >
