+1. I believe we need to remove release.sh also? Thanks, Nazeer
Thanks, Nazeer *Principal Architect, **Conflux Technologies Pvt Ltd <http://www.confluxtechnologies.com/>* *Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block, Bengaluru, Karnataka, 560043 INDIA Disclaimer: The information contained in this e-mail message and any files/attachment transmitted with it is confidential and for the sole use of the intended recipient(s) or entity identified. If you are not the intended recipient, please email: supp...@confluxtechnologies.com and destroy/delete all copies and attachment thereto along with the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email or any action taken in reliance on this e-mail is strictly prohibited and is unlawful. The recipient acknowledges that Conflux Technologies Private Limited or its subsidiaries and associated companies are unable to exercise control or ensure or guarantee the integrity of/over the contents of the information contained in e-mail transmissions. Before opening any attachments, please check. On Thu, Jan 12, 2017 at 4:25 PM, Myrle Krantz <mkra...@mifos.org> wrote: > Hey all, > > why do we have build.sh in the root directory of our release? I had > ignored it before I saw John's comment in the incubator general list. But > given that it's called build.sh, he's right: it is kind of misleading. > > Build.sh doesn't work on my computer either, but I peeked into it to see > what it's supposed to do. It looks like it will only work if the > community-app is successfully pulled from the mifos github repository in > the script. It's a little shady to be getting sources from a non-apache > git repository in the build script of what is supposed to be a source code > release. > > The mifos community-app is not even being checked as part of the Apache > Fineract release. As such, if build.sh did work, it may actually be a > potential legal problem for the ASF if the community-apps source become a > quasi-component of Fineract. > > Since it doesn't work anyways, let's delete build.sh. Then nobody can call > it and complain that our build doesn't work. > > What do you all think? > > Greets, > Myrle >
