[ 
https://issues.apache.org/jira/browse/FLAGON-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904316#comment-16904316
 ] 

Joshua Poore commented on FLAGON-441:
-------------------------------------

This blows up unit tests:

Again integration tests pass using the example page I built for forms, but now 
unit tests are failing on get initial settings and API. Except that, both work! 
setLogFilter is working on the example (form) page and all fields are 
appropriately filling in with settings (userId, url, sessionId, etc., etc.). 

 

Details below, replicate with a clone of 
[https://github.com/apache/incubator-flagon-useralejs/tree/FLAGON-434] and 'npm 
instal' then 'npm run test'. Follow example page instructions on the index_form 
version of the example page to see desired behavior vs failing unit tests.

  1) getInitialSettings

       getInitialSettings

         fetches all settings from a script tag:

     Uncaught TypeError: Cannot read property 'options' of undefined

      at Object.done (test/getInitialSettings_spec.js:73:39)

      at 
/Users/jpoore/Documents/Apache_Flagon/test/incubator-flagon-useralejs/node_modules/jsdom/lib/jsdom.js:325:18

      at processTicksAndRejections (internal/process/task_queues.js:82:9)

 

  2) getInitialSettings

       getInitialSettings

         grabs user id from params:

     Uncaught TypeError: Cannot read property 'options' of undefined

      at Object.url [as done] (test/getInitialSettings_spec.js:92:39)

      at 
/Users/jpoore/Documents/Apache_Flagon/test/incubator-flagon-useralejs/node_modules/jsdom/lib/jsdom.js:325:18

      at processTicksAndRejections (internal/process/task_queues.js:82:9)

 

  3) Userale API

       provides configs:

     Uncaught TypeError: Cannot read property 'options' of undefined

      at Object.done (test/main_spec.js:33:37)

      at 
/Users/jpoore/Documents/Apache_Flagon/test/incubator-flagon-useralejs/node_modules/jsdom/lib/jsdom.js:325:18

      at processTicksAndRejections (internal/process/task_queues.js:82:9)

 

  4) Userale API

       edits configs:

     Uncaught TypeError: Cannot read property 'options' of undefined

      at Object.done (test/main_spec.js:58:37)

      at 
/Users/jpoore/Documents/Apache_Flagon/test/incubator-flagon-useralejs/node_modules/jsdom/lib/jsdom.js:325:18

      at processTicksAndRejections (internal/process/task_queues.js:82:9)

 

  5) Userale API

       starts + stops:

     Uncaught TypeError: Cannot read property 'options' of undefined

      at Timeout._onTimeout (test/main_spec.js:75:24)

      at listOnTimeout (internal/timers.js:531:17)

      at processTimers (internal/timers.js:475:7)

 

  6) Userale API

       sends custom logs:

     Uncaught TypeError: Cannot read property 'log' of undefined

      at Object.done (test/main_spec.js:93:22)

      at 
/Users/jpoore/Documents/Apache_Flagon/test/incubator-flagon-useralejs/node_modules/jsdom/lib/jsdom.js:325:18

      at processTicksAndRejections (internal/process/task_queues.js:82:9)

 

 

> utilize sessionStorage for sessionId so that sessionId isn't cleared until 
> the tab is closed.
> ---------------------------------------------------------------------------------------------
>
>                 Key: FLAGON-441
>                 URL: https://issues.apache.org/jira/browse/FLAGON-441
>             Project: Flagon
>          Issue Type: Sub-task
>          Components: UserALE.js
>    Affects Versions: UserALE.js 2.1.0
>            Reporter: Joshua Poore
>            Assignee: Joshua Poore
>            Priority: Major
>             Fix For: UserALE.js 2.1.0
>
>
> we can build sessionId the same way as we do, but it needs to be passed to, 
> checked for, and ingested from sessionId to keep sessionId from regenerating 
> on refresh (incl. submit).



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to