confusingstraw commented on a change in pull request #61:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/61#discussion_r595227679
##########
File path: package.json
##########
@@ -5,10 +5,13 @@
"main": "build/userale-2.1.1.js",
"scripts": {
"pretest": "gulp lint",
- "test": "gulp test",
+ "test": "gulp test && npm run journey:ci",
"build": "gulp build",
"clean": "gulp clean",
"dev": "gulp dev",
+ "journey": "cypress run",
+ "journey:debug": "cypress open",
+ "journey:ci": "start-server-and-test 'node example/server.js' 8000
journey",
Review comment:
Hi Gedd, thanks for the contribution. The code looks good, and the test
seems to pass, but I needed to tweak the `package.json` scripts to be able to
run locally (on Windows 10). The error I was getting was:
```
Error: expected <NPM script name that starts server> <url or port> <NPM
script name that runs tests>
example: start-test start 8080 test
see https://github.com/bahmutov/start-server-and-test#use
```
This change seemed to do the trick though:
```suggestion
"journey:ci": "start-server-and-test example:run 8000 journey",
"example:run": "node example/server.js",
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
