poorejc commented on issue #50: URL: https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-803046568
That's great literature, @confusingstraw. Thanks! I'll checkout firing on pageHide and test against page refresh and navigation, closure. Looks like support for visibility change isn't great on safari. And, no I didn't test on safari, yet. Moz and Chrome are performing reliably though. I will note that for the life me, I just can't get sendLogs to work with any event in the page close lifecycle--visibilitychange, unload, beforeUnload. .sendBeacon is the only thing I can get to ship packages when the page closes. The only way we were getting submit events (submits trigger a page reload), was to execute sendLogs directly from the submit event (refreshEvents) handler in ./src/attachHandlers. Anyway, I'll do so further testing on pageHide and safari before I do a PR to test--I'll want some further review before we merge to test (especially since this breaks unit tests and may be undetectable my JSDOM methods--tests were passing before). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
