Morning all, Adding my vote:
+1 [X] Build and Unit Tests Pass [X] Integration Tests Pass [X] "Incubating" in References to Project and Distribution File Names [X] Signatures and Hashes Match Keys [X] DISCLAIMER, LICENSE, and NOTICE Files in Source and Binary Release Packages [X] DISCLAIMER, LICENSE, and NOTICE are consistent with ASF and Incubator Policy [X] CHANGELOG included with release distribution [X] All Source Files Have Correct ASF Headers [X] No Binary Files in Source Release Packages On Sat, May 22, 2021 at 1:19 PM Joshua Poore <poor...@apache.org> wrote: > Great work Gedd! And, AMAZING job on your very first Apache release > candidate! > > +1 > > I’ll note that there are a few src files that don’t have ALv2 headers on > them (didn’t catch these before RC packaged). These are configuration files > that are part of the testing (cypress journey test) framework, or examples, > and not actually part of the build pipeline, or src artifacts, or exports > (i.e., this is not what would be consumed by other projects as source > (through script or npm module)). I’m OK with getting license headers on > those files in the next minor release (added to Master branch ASAP). (see > RAT run below) > > > I checked: > > [ X ] Build and Unit Tests Pass > [ X ] Integration Tests Pass > [ X ] "Incubating" in References to Project and Distribution File Names > [ X ] Signatures and Hashes Match Keys > [ X ] DISCLAIMER, LICENSE, and NOTICE Files in Source and Binary Release > Packages > [ X ] DISCLAIMER, LICENSE, and NOTICE are consistent with ASF and > Incubator Policy > [ X ] CHANGELOG included with release distribution (I added in release > files (was included in src distro)) > [ X ] All Source Files Have Correct ASF Headers (see below)... > [ X ] No Binary Files in Source Release Packages > > RAT RUN: > > ***************************************************** > > ***************************************************** > Files with Apache License headers will be marked AL > Binary files (which do not require any license headers) will be marked B > Compressed archives will be marked A > Notices, licenses etc. will be marked N > B ./apache-flagon-useralejs-incubating-2.2.0-src/.DS_Store > AL ./apache-flagon-useralejs-incubating-2.2.0-src/.asf.yaml > !????? ./apache-flagon-useralejs-incubating-2.2.0-src/.babelrc > N ./apache-flagon-useralejs-incubating-2.2.0-src/DISCLAIMER > N ./apache-flagon-useralejs-incubating-2.2.0-src/KEYS > N ./apache-flagon-useralejs-incubating-2.2.0-src/LICENSE > N ./apache-flagon-useralejs-incubating-2.2.0-src/NOTICE > AL ./apache-flagon-useralejs-incubating-2.2.0-src/doap-userale.js.rdf > AL ./apache-flagon-useralejs-incubating-2.2.0-src/rollup.config.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/build/userale-2.2.0.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/build/userale-2.2.0.min.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/build/UserALEWebExtension/background.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/build/UserALEWebExtension/content.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/build/UserALEWebExtension/options.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/build/UserALEWebExtension/optionsPage.html > B > > ./apache-flagon-useralejs-incubating-2.2.0-src/build/UserALEWebExtension/icons/border-48.png > !????? > ./apache-flagon-useralejs-incubating-2.2.0-src/cypress/plugins/index.js > !????? > ./apache-flagon-useralejs-incubating-2.2.0-src/cypress/support/commands.js > !????? > ./apache-flagon-useralejs-incubating-2.2.0-src/cypress/support/index.js > AL ./apache-flagon-useralejs-incubating-2.2.0-src/example/index.html > AL ./apache-flagon-useralejs-incubating-2.2.0-src/example/index.js > AL ./apache-flagon-useralejs-incubating-2.2.0-src/example/server.js > !????? > ./apache-flagon-useralejs-incubating-2.2.0-src/example/log-label-example/index.html > N > > ./apache-flagon-useralejs-incubating-2.2.0-src/example/webpackUserAleExample/LICENSE > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/example/webpackUserAleExample/index.html > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/example/webpackUserAleExample/index.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/example/webpackUserAleExample/webpack.config.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/example/webpackUserAleExample/dist/main.js > !????? > ./apache-flagon-useralejs-incubating-2.2.0-src/journey/userale.journey.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/src/attachHandlers.js > AL ./apache-flagon-useralejs-incubating-2.2.0-src/src/configure.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/src/getInitialSettings.js > AL ./apache-flagon-useralejs-incubating-2.2.0-src/src/main.js > AL ./apache-flagon-useralejs-incubating-2.2.0-src/src/packageLogs.js > AL ./apache-flagon-useralejs-incubating-2.2.0-src/src/sendLogs.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/src/UserALEWebExtension/background.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/src/UserALEWebExtension/content.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/src/UserALEWebExtension/globals.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/src/UserALEWebExtension/messageTypes.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/src/UserALEWebExtension/options.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/src/UserALEWebExtension/optionsPage.html > B > > ./apache-flagon-useralejs-incubating-2.2.0-src/src/UserALEWebExtension/icons/border-48.png > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/src/UserALEWebExtension/public/index.html > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/test/attachHandlers_spec.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/test/configure_spec.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/test/getInitialSettings_fetchAll.html > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/test/getInitialSettings_spec.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/test/getInitialSettings_userParam.html > AL ./apache-flagon-useralejs-incubating-2.2.0-src/test/main.html > AL ./apache-flagon-useralejs-incubating-2.2.0-src/test/main_spec.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/test/packageLogs_spec.js > AL > ./apache-flagon-useralejs-incubating-2.2.0-src/test/sendLogs_spec.js > AL ./apache-flagon-useralejs-incubating-2.2.0-src/test/testUtils.js > > > > > On May 21, 2021, at 8:09 AM, Gedd Johnson <geddjohns...@gmail.com> > wrote: > > > > Hi Folks, > > Please VOTE on the Apache Flagon 2.2.0 Release Candidate #1. > > > > About Flagon: http://flagon.incubator.apache.org/ > > > > This Minor release includes: > > > > 1. Adding a page load log feature > > 2. Refactoring the build pipeline using Rollup > > 3. Adding a journey testing suite > > 4. Fixing a bug with sendOnClose > > > > We solved 21 issues: > > https://github.com/apache/incubator-flagon-useralejs/projects/7 > > > > Git source tag (2bf71ee): > > > https://github.com/apache/incubator-flagon-useralejs/releases/tag/2.2.0-rc1 > > > > Staging repo: https://dist.apache.org/repos/dist/dev/incubator/flagon/ > > > > Source Release Artifacts: > > > https://dist.apache.org/repos/dist/dev/incubator/flagon/apache-flagon-useralejs-incubating-2.2.0-RC1/ > > > > PGP release keys (signed using A88C905BD4516D4C): > > https://dist.apache.org/repos/dist/dev/incubator/flagon/KEYS > > > > Link to successful Github CI Build: > > https://github.com/apache/incubator-flagon-useralejs/actions > > > > Reference the useralejs testing framework to assist in your unit and > > integration tests: > > > https://cwiki.apache.org/confluence/display/FLAGON/UserALE.js+Testing+Framework > > > > Vote will be open for 72 hours. Please VOTE as follows: > > > > [ ] +1, let's get it released!!! > > [ ] +/-0, fine, but consider to fix few issues before... > > [ ] -1, nope, because... (and please explain why) > > > > Along with your VOTE, please indicate testing and checks you've made > > against build artifacts, src, and documentation: > > > > [ ] Build and Unit Tests Pass > > [ ] Integration Tests Pass > > [ ] "Incubating" in References to Project and Distribution File Names > > [ ] Signatures and Hashes Match Keys > > [ ] DISCLAIMER, LICENSE, and NOTICE Files in Source and Binary Release > > Packages > > [ ] DISCLAIMER, LICENSE, and NOTICE are consistent with ASF and Incubator > > Policy > > [ ] CHANGELOG included with release distribution > > [ ] All Source Files Have Correct ASF Headers > > [ ] No Binary Files in Source Release Packages > > > > Thank you to everyone that is able to VOTE as well as everyone that > > contributed to Apache Flagon 2.2.0 > >
