Jyyjy opened a new issue, #312: URL: https://github.com/apache/incubator-flagon-useralejs/issues/312
Currently you can only set one map callback and one filter callback in packageLogs.js. This is an issue because when writing custom scripts in conent.js, the filter callback is set in injectScript(). So currently a user cannot set their own filter function. Even if the intention is to restrict content.js to a single filter callback, the one being set in injectScript() doesn't actually filter. The filter callback being set just sends the log to the background script. Furthermore, there is not a huge difference between the map and filter callbacks. So as a solution to the filter problem above, I am working on having a single function to add callbacks to the various package log functions, which can be called multiple times. so instead of this: filter(foo) map(bar) we can do this: addCallback(foo) addCallback(bar) addCallback([baz, qux]) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@flagon.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
