brucearctor commented on PR #347:
URL: 
https://github.com/apache/incubator-flagon-useralejs/pull/347#issuecomment-1461102679

   in this case, `JSON Schema` probably makes sense.  Personally, generally, I 
try to avoid use of JSON Schema and err towards defining 
[protobuf](https://protobuf.dev/) - but that is less prevalent in the 
web-focused world [ LOL -- though, at times, I even will send a proto over 
REST, and not using [gRPC](https://grpc.io/) or [gRPC 
Web](https://grpc.io/docs/platforms/web/basics/).  
   
   Also curious, why add schema checks via an existing test file - rather than 
creating a new test file focused on tests specifically for schema?  
   
   If defining a schema that is being tested against, we might want that very 
clearly referenced/findable.  That might be in /tests if well defined, but 
ensuring that is clearly published would potentially be valuable to users.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@flagon.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to