This vote is being canceled, and this release candidate will not move forward.
- Jason > On Oct 9, 2023, at 11:39 PM, Joshua Poore <poor...@apache.org> wrote: > > btw— > > for those interested, here is how I tested different python environments > within the Poetry venv: > > pyenv install anaconda3-2023.07-2 > pyenv shell anaconda3-2023.07-2 (python —version = 3.11.4) > poetry env use python3.11 (python —version = 3.11.4) > poetry install > poetry shell > make test > > https://github.com/pyenv/pyenv#homebrew-in-macos > <pyenv.png> > > [pyenv/pyenv: Simple Python version > management](https://github.com/pyenv/pyenv#homebrew-in-macos) > [github.com](https://github.com/pyenv/pyenv#homebrew-in-macos) > > Big thanks to Jason for introducing me to pyenv! > > -J > >> On Oct 9, 2023, at 11:26 PM, Joshua Poore <poor...@apache.org> wrote: >> >> +0 for me. >> >> VERY close, but needs some minor changes to documentation to guide dev users >> through appropriate Poetry installation. This would require a new VOTE as it >> will require another RC. >> >> I tested builds, tests, and deployment of the Package into a Notebook env >> via Test Py installation. I tested in 3.9.x and 3.11.x environments. The >> package tests well when some assumptions that aren’t currently clear in the >> documentation are met. >> >> Poetry can be installed via PyPI (pip), however, this will result in >> failures during build and testing. Poetry needs to be installed as a >> stand-alone virtual environment through Poetry’s own custom installer, or >> via pipx (separate python package), in order for python packages installed >> during ‘poetry install’ to be accessible to scripts running through the >> Poetry venv shell. I strongly success that the README point to Poetry >> documentation so that it is appropriately installed. Poetry is a core >> dependency for builds, so users would benefit from a bit more context. >> >> Once Poetry was appropriately installed, I was able to successfully build in >> both standard Python environments and Anaconda environments (using the >> ‘poetry env use’ command and pyenv). >> >> Again, excellent release candidate! I think this is so close—just some docs >> updates. I will continue reviewing src for basic compliance issues. >> >> Thanks again for the great work! >> >> Josh >> >>> On Oct 7, 2023, at 10:01 PM, Joshua Poore <poor...@apache.org> wrote: >>> >>> I was referring to Python’s own docs :). I found Test Py’s own docs let me >>> to failure. I got the snippet below from SO. >>> >>> I think these instructions would go into release procs docs, not in source. >>> >>>> On Oct 7, 2023, at 9:24 PM, Evan Jones <evan.a.jon...@gmail.com> wrote: >>>> >>>> Josh, >>>> >>>> This is a good catch. We should improve the documentation on this front. >>>> >>>> Best >>>> >>>> Evan Jones >>>> Website: www.ea-jones.com >>>> >>>> On Sat, Oct 7, 2023 at 8:52 PM Joshua Poore <poor...@apache.org> wrote: >>>> >>>>> Hi folks, >>>>> >>>>> If you’re testing the distill package (and amped like me about this >>>>> RC!!!), I found that docs on how to call the package into your python IDE >>>>> or notebook from TestPy are a bit rough. >>>>> >>>>> this call works: >>>>> >>>>> pip install -i https://test.pypi.org/pypi/ --extra-index-url >>>>> https://pypi.org/simple flagon-distill >>>>> >>>>>> On Oct 5, 2023, at 11:47 AM, proton_mail_bridge < >>>>> >>>>> jason_...@protonmail.com.INVALID> wrote: >>>>> >>>>>> Hi Folks, >>>>>> >>>>>> Let’s try this again, please VOTE on the Apache Flagon Distill 0.1.0 >>>>> >>>>> Release Candidate #01. >>>>> >>>>>> About Flagon: http://flagon.incubator.apache.org/ >>>>>> This is the first Beta release. >>>>>> >>>>>> Git source tag (0.1.0-rc01): >>>>> >>>>> https://github.com/apache/flagon-distill/releases/tag/0.1.0-rc01 >>>>> >>>>>> Staging repo: https://dist.apache.org/repos/dist/dev/incubator/flagon/ >>>>>> Source Release Artifacts: [ >>>>> >>>>> https://dist.apache.org/repos/dist/dev/flagon/apache-flagon-distill-0.1.0-RC-01/](https://dist.apache.org/repos/dist/dev/flagon/apache-flagon-distill-0.0.6-RC-01/) >>>>> >>>>>> PGP release keys: https://dist.apache.org/repos/dist/dev/flagon/KEYS >>>>>> Successful Github Actions Build and Tests: >>>>> >>>>> https://github.com/apache/flagon-distill/actions/runs/6420477503 >>>>> >>>>>> PyPi Test Repo: https://test.pypi.org/project/flagon-distill/ >>>>>> >>>>>> Vote will be open for 72 hours. >>>>>> Please VOTE as follows: >>>>>> [ ] +1, let's get it released!!! >>>>>> [ ]+/-0, fine, but consider to fix few issues before… >>>>>> [ ] -1, nope, because... (and please explain why) >>>>>> >>>>>> Along with your VOTE, please indicate testing and checks you've made >>>>> >>>>> against build artifacts, src, and documentation: >>>>> >>>>>> [ ] Build and Unit Tests Pass >>>>>> [ ] Signatures and Hashes Match Keys >>>>>> [ ] DISCLAIMER, LICENSE, and NOTICE Files in Source and Binary Release >>>>> >>>>> Packages >>>>> >>>>>> [ ] DISCLAIMER, LICENSE, and NOTICE are consistent with ASF and >>>>> >>>>> Incubator Policy >>>>> >>>>>> [ ] CHANGELOG included with release distribution >>>>>> [ ] All Source Files Have Correct ASF Headers >>>>>> [ ] No Binary Files in Source Release Packages >>>>>> >>>>>> Thank you to everyone that is able to VOTE as well as everyone that >>>>> >>>>> contributed to Apache Flagon 0.0.6!
