Hi there are 2 BufferCache usage. Basically we cache *allocations* (not values) of StringBuilder and char[] (parser buffer). Name is maybe not the best one, BufferRecycle can be better. Fleece factories are thread safe, (then parser, generator etc are not).
It really changes the performances but a better implementation (with no dependency) would work. Any proposal? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-06-27 16:22 GMT+02:00 Hendrik Dev <[email protected]>: > Hello, > > what is the main purpose of org.apache.fleece.core.BufferCache<T>? > > Is it to be a real thread local cache (because we excpect that we have > many parallel threads running) or just a cache which use threadlocals > as a kind of an internal implementation (not expecting really parallel > threads)? > > The comment within this class is > "// alloc are expensive so using a very trivial buffer, we remove from > TL to say we use it and reset it when we are done (close)" > Which allocations are meant? StringBuilder, char[], <T>, ... > > Is fleece supposed to be a threadsafe library? (Beyond wahts marked to > be thread-safe in the apispecs) > > Thanks > Hendrik (salyh) >
